Skip to content

bpo-34995: Maintain func.__isabstractmethod__ in functools.cached_property #9904

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mwilbz wants to merge 6 commits into from
Closed

bpo-34995: Maintain func.__isabstractmethod__ in functools.cached_property #9904

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
da3ec33
bpo-34995: Maintain func.__isabstractmethod__ in functools.cached_pro…
Oct 15, 2018
bfdc249
Add news entry
Oct 15, 2018
16c0372
Only set __isabstractmethod__ if wrapapped func sets it
Oct 25, 2018
db8dcd7
Check for __isabstractmethod__ with try/except
Oct 25, 2018
1c91dd2
Add negative test case for abstract cached_property
Oct 25, 2018
511c14f
Avoid long lines
Oct 26, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add news entry
  • Loading branch information
Matt Wilber
Matt Wilber committed Oct 15, 2018
commit bfdc2499a620b8688f136d30c5c4dca672a489d0
1 change: 1 addition & 0 deletions Misc/NEWS.d/next/Library/2018-10-15-23-56-39.bpo-34995.kNA9ge.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Maintain wrapped method's __isabstractmethod__ in functools.cached_property

@vstinner vstinner Oct 25, 2018

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest:

:func:`functools.cached_property` now also copies the wrapped method's ``__isabstractmethod__`` attribute.