Skip to content

bpo-34890: Make iscoroutinefunction, isgeneratorfunction and isasyncgenfunction work with functools.partial #9903

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pablogsal merged 8 commits into from
Oct 26, 2018
Merged

bpo-34890: Make iscoroutinefunction, isgeneratorfunction and isasyncgenfunction work with functools.partial #9903

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
633c497
Make iscoroutinefunction, isgeneratorfunction and isasyncgenfunction …
pablogsal Oct 15, 2018
41f7f60
Simplify code, rename variables and add test for nested partials
pablogsal Oct 15, 2018
b65500e
fixup! Simplify code, rename variables and add test for nested partials
pablogsal Oct 15, 2018
3b841ac
Add _unwrap_partial helper to reduce repetition
pablogsal Oct 15, 2018
adb5db6
Use module import in tests
pablogsal Oct 15, 2018
617688e
Add extra check to Lib/asyncio/coroutines:coroutine for partial to pr…
pablogsal Oct 15, 2018
caddd21
Change test that checks __reprl__ of partial
pablogsal Oct 16, 2018
0585757
Refactor helper function and document changes
pablogsal Oct 25, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Use module import in tests
  • Loading branch information
@pablogsal
pablogsal committed Oct 15, 2018
commit adb5db66a9519281510d9e1e3d54bb7708476099
16 changes: 10 additions & 6 deletions Lib/test/test_inspect.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@
import collections
import datetime
import functools
from functools import partial
import importlib
import inspect
import io
Expand Down Expand Up @@ -175,35 +174,40 @@ def test_iscoroutine(self):
inspect.iscoroutinefunction(gen_coroutine_function_example))
self.assertFalse(
inspect.iscoroutinefunction(
partial(partial(gen_coroutine_function_example))))
functools.partial(functools.partial(
gen_coroutine_function_example))))
self.assertFalse(inspect.iscoroutine(gen_coro))

self.assertTrue(
inspect.isgeneratorfunction(gen_coroutine_function_example))
self.assertTrue(
inspect.isgeneratorfunction(
partial(partial(gen_coroutine_function_example))))
functools.partial(functools.partial(
gen_coroutine_function_example))))
self.assertTrue(inspect.isgenerator(gen_coro))

self.assertTrue(
inspect.iscoroutinefunction(coroutine_function_example))
self.assertTrue(
inspect.iscoroutinefunction(
partial(partial(coroutine_function_example))))
functools.partial(functools.partial(
coroutine_function_example))))
self.assertTrue(inspect.iscoroutine(coro))

self.assertFalse(
inspect.isgeneratorfunction(coroutine_function_example))
self.assertFalse(
inspect.isgeneratorfunction(
partial(partial(coroutine_function_example))))
functools.partial(functools.partial(
coroutine_function_example))))
self.assertFalse(inspect.isgenerator(coro))

self.assertTrue(
inspect.isasyncgenfunction(async_generator_function_example))
self.assertTrue(
inspect.isasyncgenfunction(
partial(partial(async_generator_function_example))))
functools.partial(functools.partial(
async_generator_function_example))))
self.assertTrue(inspect.isasyncgen(async_gen_coro))

coro.close(); gen_coro.close(); # silence warnings
Expand Down