Skip to content

bpo-34989: python-gdb.py: fix current_line_num() #9889

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vstinner merged 2 commits into from
Oct 15, 2018
Merged

bpo-34989: python-gdb.py: fix current_line_num() #9889

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a74366a
bpo-34989: python-gdb.py: fix current_line_num()
vstinner Oct 15, 2018
37b347b
move an empty line for readability
vstinner Oct 15, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
move an empty line for readability
  • Loading branch information
@vstinner
vstinner committed Oct 15, 2018
commit 37b347bd28a4466f5297e10f281117ee81c72053
2 changes: 1 addition & 1 deletion Tools/gdb/libpython.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -954,8 +954,8 @@ def current_line(self):
lineno = self.current_line_num()
if lineno is None:
return '(failed to get frame line number)'

@ambv ambv Oct 15, 2018

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tiny nit: that could also have a blank line after to make it obvious you're returning early.

@vstinner vstinner Oct 15, 2018

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I concur, done.

filename = self.filename()

filename = self.filename()
try:
with open(os_fsencode(filename), 'r') as fp:
lines = fp.readlines()
Expand Down