Skip to content

gh-98852: Add extra type check to avoid a bug with parameterizing gen… #98862

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Eclips4 wants to merge 2 commits into from
Closed

gh-98852: Add extra type check to avoid a bug with parameterizing gen… #98862

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ffae614
gh-98852: Add extra type check to avoid a bug with parameterizing gen…
Eclips4 Oct 29, 2022
920c3f4
📜🤖 Added by blurb_it.
blurb-it[bot] Oct 29, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
gh-98852: Add extra type check to avoid a bug with parameterizing gen… 
…erics
  • Loading branch information
@Eclips4
Eclips4 committed Oct 29, 2022
commit ffae614cda8df36bd8b5905798a09b7d84b2ff8a
2 changes: 2 additions & 0 deletions Lib/typing.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1440,6 +1440,8 @@ def _determine_new_args(self, args):
substfunc = getattr(old_arg, '__typing_subst__', None)
if substfunc:
new_arg = substfunc(new_arg_by_param[old_arg])
elif not isinstance(old_arg, (_GenericAlias, GenericAlias, types.UnionType)):
new_arg = old_arg
else:
subparams = getattr(old_arg, '__parameters__', ())
if not subparams:
Expand Down