Skip to content

gh-97850: Deprecate find_loader and get_loader in pkgutil #98520

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
brettcannon merged 14 commits into from
May 3, 2023
Merged

gh-97850: Deprecate find_loader and get_loader in pkgutil #98520

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
b7de6df
gh-97850: Deprecate `find_module` and `get_module` in `pkgutil`
sobolevn Oct 21, 2022
b1e6d4d
Address review
sobolevn Nov 9, 2022
d55a9b7
Update Misc/NEWS.d/next/Library/2022-10-21-16-23-31.gh-issue-97850.N4…
sobolevn Nov 9, 2022
e282911
Use just one module
sobolevn Nov 26, 2022
4f9a697
Merge branch 'deprecate-pkgutil-get-find-loader' of https://github.co…
sobolevn Nov 26, 2022
4222f23
Merge branch 'main' into deprecate-pkgutil-get-find-loader
brettcannon Jan 21, 2023
817f2da
Apply suggestions from code review
sobolevn Feb 5, 2023
8b116d9
Update Misc/NEWS.d/next/Library/2022-10-21-16-23-31.gh-issue-97850.N4…
sobolevn Feb 5, 2023
e94a6f3
Merge branch 'main' into deprecate-pkgutil-get-find-loader
sobolevn Apr 11, 2023
e073fac
Mention deprecation in `pkgutil` docs
sobolevn Apr 19, 2023
1e26981
Address review
sobolevn Apr 19, 2023
24badea
Merge branch 'main' into deprecate-pkgutil-get-find-loader
arhadthedev Apr 30, 2023
619c4dc
Apply suggestions from code review
brettcannon May 3, 2023
b65576a
Merge branch 'main' into deprecate-pkgutil-get-find-loader
sobolevn May 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Address review
  • Loading branch information
@sobolevn
sobolevn committed Apr 19, 2023
commit 1e26981c5c7795aab510abf7b2c2c2f23e054886
4 changes: 2 additions & 2 deletions Doc/library/pkgutil.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ support.
.. versionchanged:: 3.4
Updated to be based on :pep:`451`

.. deprecated:: 3.12
.. deprecated-removed:: 3.12 3.14
Use :func:`importlib.util.find_spec` instead.


Expand Down Expand Up @@ -127,7 +127,7 @@ support.
.. versionchanged:: 3.4
Updated to be based on :pep:`451`

.. deprecated:: 3.12
.. deprecated-removed:: 3.12 3.14
Use :func:`importlib.util.find_spec` instead.


Expand Down
10 changes: 5 additions & 5 deletions Doc/whatsnew/3.12.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -572,11 +572,6 @@ Deprecated
:exc:`ImportWarning`).
(Contributed by Brett Cannon in :gh:`65961`.)

* :func:`pkgutil.find_loader` and :func:`pkgutil.get_loader`
now raise :exc:`DeprecationWarning`;
use :func:`importlib.util.find_spec` instead.
(Contributed by Nikita Sobolev in :gh:`97850`.)

* The :meth:`~asyncio.get_event_loop` method of the
default event loop policy now emits a :exc:`DeprecationWarning` if there
is no current event loop set and it decides to create one.
Expand Down Expand Up @@ -695,6 +690,11 @@ Pending Removal in Python 3.14
* The *onerror* argument of :func:`shutil.rmtree` is deprecated in 3.12,
and will be removed in 3.14.

* :func:`pkgutil.find_loader` and :func:`pkgutil.get_loader`
now raise :exc:`DeprecationWarning`;
use :func:`importlib.util.find_spec` instead.
(Contributed by Nikita Sobolev in :gh:`97850`.)

Pending Removal in Future Versions
----------------------------------

Expand Down