Skip to content

bpo-33234 Improve list() pre-sizing for inputs with known lengths (no __length_hint__) #9846

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pablogsal merged 10 commits into from
Oct 28, 2018
Merged

bpo-33234 Improve list() pre-sizing for inputs with known lengths (no __length_hint__) #9846

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
7602879
Improve list() pre-sizing for inputs with known lengths
pablogsal Apr 17, 2018
39a8757
Preallocate only when __len__ is available to avoid loss of performan…
pablogsal Oct 13, 2018
ab450b3
Fix NEWS entry and correct style
pablogsal Oct 15, 2018
717ca67
Use _PyObject_HasLen to check if the object has lenght to avoid overhead
pablogsal Oct 23, 2018
b678442
Simplify implementation and don't capture all expections on error
pablogsal Oct 23, 2018
b40bd62
Add assert and fix formatting
pablogsal Oct 25, 2018
3837486
Remove uneeded test modification
pablogsal Oct 25, 2018
b6ff7ce
Don't preallocate if list is modified when calling PyObject_Size
pablogsal Oct 26, 2018
e7f8c46
Improve readability in the error handling branch
pablogsal Oct 26, 2018
0a6c8ba
Capture only TypeError as suggested by Serhiy
pablogsal Oct 28, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add assert and fix formatting
  • Loading branch information
@pablogsal
pablogsal committed Oct 25, 2018
commit b40bd623c5536dd90a4cc8ebbc72fc5ff0889ca3
5 changes: 4 additions & 1 deletion Objects/listobject.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,6 +79,8 @@ list_resize(PyListObject *self, Py_ssize_t newsize)
static int
list_preallocate_exact(PyListObject *self, Py_ssize_t size)
{
assert(self->ob_item == NULL);

PyObject **items;
size_t allocated;

Expand Down Expand Up @@ -2679,7 +2681,8 @@ list___init___impl(PyListObject *self, PyObject *iterable)
if (iter_len == -1) {
if (PyErr_ExceptionMatches(PyExc_Exception)) {

@serhiy-storchaka serhiy-storchaka Oct 26, 2018

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What tests will fail if not silence any exceptions at all?

@pablogsal pablogsal Oct 26, 2018 •
edited
Loading

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At least the following:

test_generators failed
**********************************************************************
File "/home/pablogsal/github/cpython/Lib/test/test_generators.py", line ?, in test.test_generators.__test__.weakref
Failed example:
    list(p)
Exception raised:
    Traceback (most recent call last):
      File "/home/pablogsal/github/cpython/Lib/doctest.py", line 1329, in __run
        compileflags, 1), test.globs)
      File "<doctest test.test_generators.__test__.weakref[9]>", line 1, in <module>
        list(p)
    TypeError: object of type 'generator' has no len()
**********************************************************************
1 items had failures:
   1 of  10 in test.test_generators.__test__.weakref
***Test Failed*** 1 failures.


test_genexps failed
**********************************************************************
File "/home/pablogsal/github/cpython/Lib/test/test_genexps.py", line ?, in test.test_genexps.__test__.doctests
Failed example:
    list(p)
Exception raised:
    Traceback (most recent call last):
      File "/home/pablogsal/github/cpython/Lib/doctest.py", line 1329, in __run
        compileflags, 1), test.globs)
      File "<doctest test.test_genexps.__test__.doctests[75]>", line 1, in <module>
        list(p)
    TypeError: object of type 'generator' has no len()
**********************************************************************
1 items had failures:
   1 of  76 in test.test_genexps.__test__.doctests
***Test Failed*** 1 failures.

@serhiy-storchaka serhiy-storchaka Oct 27, 2018

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How can _PyObject_HasLen() return true for generators?

@serhiy-storchaka serhiy-storchaka Oct 27, 2018

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, it is not true generator, it is a weakref. What if silence just TypeError?

@pablogsal pablogsal Oct 27, 2018

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am a bit afraid if someone has similar tests/usage like these two cases and then they will receive new errors as raising all exceptions would be technically a backwards incompatible change. But if you think we should raise (maybe ignoring TypeError) I am happy to change the implementation.

@serhiy-storchaka serhiy-storchaka Oct 28, 2018

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See PyObject_LengthHint().

@pablogsal pablogsal Oct 28, 2018

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done in 0a6c8ba

PyErr_Clear();
} else {
}
else {

@vstinner vstinner Oct 26, 2018

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpick: for readability, I suggest to invert the if condition and exchange the true/false blocks, and move PyErr_Clear() after the if:

if (!not exception) { return -1; }
PyErr_Clear();

return -1;
}
}
Expand Down