Skip to content

gh-93453: No longer create an event loop in get_event_loop() #98440

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ambv merged 6 commits into from
Dec 6, 2022
Merged

gh-93453: No longer create an event loop in get_event_loop() #98440

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
e789d32
gh-93453: No longer create an event loop in get_event_loop()
serhiy-storchaka Jun 2, 2022
4a6e405
Merge branch 'main' into asyncio-get_event_loop2
serhiy-storchaka Nov 30, 2022
380c158
Fix test_fork_not_share_event_loop.
serhiy-storchaka Nov 30, 2022
a09eccb
Update docs.
serhiy-storchaka Dec 1, 2022
72223eb
Merge branch 'main' into asyncio-get_event_loop2
ambv Dec 5, 2022
0b4cbfe
Address wording nits
ambv Dec 5, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update docs.
  • Loading branch information
@serhiy-storchaka
serhiy-storchaka committed Dec 1, 2022
commit a09eccb928839a45417fbded769d6645f15ce9f8
6 changes: 6 additions & 0 deletions Doc/library/asyncio-eventloop.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,12 @@ an event loop:
Consider also using the :func:`asyncio.run` function instead of using
lower level functions to manually create and close an event loop.

.. note::
In Python versions 3.10.0--3.10.8 and 3.11.0 this function
(and other functions which used it implicitly) emmitted a
:exc:`DeprecationWarning` if there was no running event loop, even if
the current loop was set.

.. function:: set_event_loop(loop)

Set *loop* as a current event loop for the current OS thread.
Expand Down
12 changes: 12 additions & 0 deletions Doc/whatsnew/3.12.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -682,6 +682,18 @@ Changes in the Python API
around process-global resources, which are best managed from the main interpreter.
(Contributed by Dong-hee Na in :gh:`99127`.)

* :func:`asyncio.get_event_loop` and many other :mod:`asyncio` functions like
:func:`~asyncio.ensure_future`, :func:`~asyncio.shield` or
:func:`~asyncio.gather`, and also the
:meth:`~asyncio.BaseDefaultEventLoopPolicy.get_event_loop` method of
:class:`~asyncio.BaseDefaultEventLoopPolicy` now raise an :exc:`RuntimeError`
if called when there is no running event loop and the current event loop was
not set.
Previously they implicitly created and set a new current event loop.
:exc:`DeprecationWarning` is no longer emitted if there is no running
event loop but the current event loop was set.
(Contributed by Serhiy Storchaka in :gh:`93453`.)


Build Changes
=============
Expand Down