Skip to content

gh-96151: Use a private name for passing builtins to dataclass #98143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ericvsmith merged 8 commits into from
Oct 31, 2022
Merged

gh-96151: Use a private name for passing builtins to dataclass #98143

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
3e03d52
gh-96151: Use a private name for passing builtins to dataclass
hauntsaninja Oct 10, 2022
7f9f91e
📜🤖 Added by blurb_it.
blurb-it[bot] Oct 10, 2022
2d5f290
add a test case
hauntsaninja Oct 11, 2022
d7e8782
separate out test
hauntsaninja Oct 11, 2022
96cc82b
use dunder builtins
hauntsaninja Oct 17, 2022
e7456f8
actually, prefix with __dataclass
hauntsaninja Oct 30, 2022
8f6e968
Remove builtins logic from _create_fn
hauntsaninja Oct 31, 2022
9d44429
also update comment
hauntsaninja Oct 31, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
add a test case
  • Loading branch information
@hauntsaninja
hauntsaninja committed Oct 11, 2022
commit 2d5f29026e2a0376edc5ac9563966dbbf5e27c64
4 changes: 3 additions & 1 deletion Lib/test/test_dataclasses.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -254,8 +254,10 @@ def test_field_named_object_frozen(self):
@dataclass(frozen=True)
class C:
object: str
c = C('foo')
BUILTINS: int # gh-96151
c = C('foo', 5)
self.assertEqual(c.object, 'foo')
self.assertEqual(c.BUILTINS, 5)

@ericvsmith ericvsmith Oct 11, 2022

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please create a separate function for this, and don't mix it in with existing tests. Maybe test_field_named_BUILTINS or similar.

@hauntsaninja hauntsaninja Oct 11, 2022

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the review, made the change :-)


def test_field_named_like_builtin(self):
# Attribute names can shadow built-in names
Expand Down