Skip to content

[3.10] gh-94808: Cover %p in PyUnicode_FromFormat (GH-96677) #98032

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JelleZijlstra merged 2 commits into from
Oct 7, 2022
Merged

[3.10] gh-94808: Cover %p in PyUnicode_FromFormat (GH-96677) #98032

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fa3759d
gh-94808: Cover `%p` in `PyUnicode_FromFormat` (GH-96677)
sobolevn Oct 7, 2022
5ff6aa4
Fix for exotic OSes
JelleZijlstra Oct 7, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Fix for exotic OSes
  • Loading branch information
@JelleZijlstra
JelleZijlstra authored Oct 7, 2022
commit 5ff6aa4a6cf70c6c45f7b8404079457ee0ed1efe
4 changes: 2 additions & 2 deletions Lib/test/test_unicode.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2763,15 +2763,15 @@ def check_format(expected, format, *args):
# We cannot test the exact result,
# because it returns a hex representation of a C pointer,
# which is going to be different each time. But, we can test the format.
p_format_regex = r'^0x[a-zA-Z0-9]{8,}$'
p_format_regex = r'^0x[a-zA-Z0-9]{3,}$'
p_format1 = PyUnicode_FromFormat(b'%p', 'abc')
self.assertIsInstance(p_format1, str)
self.assertRegex(p_format1, p_format_regex)

p_format2 = PyUnicode_FromFormat(b'%p %p', '123456', b'xyz')
self.assertIsInstance(p_format2, str)
self.assertRegex(p_format2,
r'0x[a-zA-Z0-9]{8,} 0x[a-zA-Z0-9]{8,}')
r'0x[a-zA-Z0-9]{3,} 0x[a-zA-Z0-9]{3,}')

# Extra args are ignored:
p_format3 = PyUnicode_FromFormat(b'%p', '123456', None, b'xyz')
Expand Down