Skip to content

GH-88968: Reject socket that is already used as a transport #98010

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gvanrossum merged 4 commits into from
Oct 7, 2022
Merged

GH-88968: Reject socket that is already used as a transport #98010

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6783dda
In _make_socket_transport, ensure the fd isn't already used by a tran…
gvanrossum Oct 7, 2022
fda2111
Make existing tests pass
gvanrossum Oct 7, 2022
6224b18
Test that _ensure_fd_no_transport is called
gvanrossum Oct 7, 2022
1c348f1
Same check for _make_ssl_transport and _make_datagram_transport
gvanrossum Oct 7, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Test that _ensure_fd_no_transport is called
  • Loading branch information
@gvanrossum
gvanrossum committed Oct 7, 2022
commit 6224b183dda2d4a845933a1c6aa5d614acab290c
1 change: 1 addition & 0 deletions Lib/test/test_asyncio/test_selector_events.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,7 @@ def test_make_socket_transport(self):
self.loop._ensure_fd_no_transport = mock.Mock()
transport = self.loop._make_socket_transport(m, asyncio.Protocol())
self.assertIsInstance(transport, _SelectorSocketTransport)
self.assertEqual(self.loop._ensure_fd_no_transport.call_count, 1)

# Calling repr() must not fail when the event loop is closed
self.loop.close()
Expand Down