Skip to content

gh-86298: Ensure that __loader__ and __spec__.loader agree in warnings.warn_explicit() #97803

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
miss-islington merged 17 commits into from
Oct 7, 2022
Merged

gh-86298: Ensure that __loader__ and __spec__.loader agree in warnings.warn_explicit() #97803

Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
37b581a
PoC for checking both __loader__ and __spec__.loader
warsaw Oct 3, 2022
049910b
Merge branch 'main' into issue-86298
warsaw Oct 3, 2022
317e253
Add a test for the __loader__ == __spec__.loader cases
warsaw Oct 4, 2022
428d863
Add news
warsaw Oct 4, 2022
06d686d
Merge branch 'main' into issue-86298
warsaw Oct 4, 2022
fc50fe1
Update some documentation
warsaw Oct 4, 2022
1066b9f
Use a helper function
warsaw Oct 6, 2022
4602366
Merge branch 'main' into issue-86298
warsaw Oct 6, 2022
831f832
Pass warnings tests
warsaw Oct 6, 2022
37254cf
Merge branch 'main' into issue-86298
warsaw Oct 6, 2022
fe9d62e
Move warnings tests to helper tests
warsaw Oct 6, 2022
3bcdba9
Clean up a few last minute things
warsaw Oct 6, 2022
f5cef9c
Merge branch 'main' into issue-86298
warsaw Oct 7, 2022
5600c9c
Update Lib/importlib/_bootstrap_external.py
warsaw Oct 7, 2022
8631e53
Update Lib/test/test_importlib/import_/test_helpers.py
warsaw Oct 7, 2022
b1b0d86
Update Lib/test/test_importlib/import_/test_helpers.py
warsaw Oct 7, 2022
823400c
Merge branch 'main' into issue-86298
warsaw Oct 7, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update Lib/test/test_importlib/import_/test_helpers.py 
Co-authored-by: Brett Cannon <brett@python.org>
  • Loading branch information
@warsaw @brettcannon
warsaw and brettcannon authored Oct 7, 2022
commit b1b0d864245cb366e762f431189465c9d955d5d5
1 change: 1 addition & 0 deletions Lib/test/test_importlib/import_/test_helpers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,6 +96,7 @@ def test_gh86298_loader_is_none_and_no_spec(self):
# 2022-10-06(warsaw): For backward compatibility with the
# implementation in _warnings.c, this can't raise an
# AttributeError. See _bless_my_loader() in _bootstrap_external.py
# If working with a module:
## self.assertRaises(
Comment thread
warsaw marked this conversation as resolved.
## AttributeError, _bootstrap_external._bless_my_loader,
## bar.__dict__)
Expand Down