Skip to content

bpo-33613: Fix test_semaphore_tracker signal tests when using -Werror #9778

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pablogsal merged 2 commits into from
Oct 10, 2018
Merged

bpo-33613: Fix test_semaphore_tracker signal tests when using -Werror #9778

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6a8fd14
Fix test_semaphore_tracker signal tests when using -Werror
pablogsal Oct 9, 2018
c72cd3d
fixup! Fix test_semaphore_tracker signal tests when using -Werror
pablogsal Oct 10, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Fix test_semaphore_tracker signal tests when using -Werror
  • Loading branch information
@pablogsal
pablogsal committed Oct 9, 2018
commit 6a8fd1463134c43228e1d581b381a7b1b4fff8cd
4 changes: 3 additions & 1 deletion Lib/test/_test_multiprocessing.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4549,6 +4549,7 @@ def check_semaphore_tracker_death(self, signum, should_die):
os.kill(pid, signal.SIGKILL)
os.waitpid(pid, 0)
with warnings.catch_warnings(record=True) as all_warn:
warnings.simplefilter("always")

@serhiy-storchaka serhiy-storchaka Oct 10, 2018

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aren't the recorded warnings just ignored?

_semaphore_tracker.ensure_running()
pid = _semaphore_tracker._pid

Expand All @@ -4557,6 +4558,7 @@ def check_semaphore_tracker_death(self, signum, should_die):

ctx = multiprocessing.get_context("spawn")
with warnings.catch_warnings(record=True) as all_warn:
warnings.simplefilter("always")
sem = ctx.Semaphore()
sem.acquire()
sem.release()
Expand All @@ -4569,7 +4571,7 @@ def check_semaphore_tracker_death(self, signum, should_die):
if should_die:
self.assertEqual(len(all_warn), 1)
the_warn = all_warn[0]
issubclass(the_warn.category, UserWarning)
self.assertTrue(issubclass(the_warn.category, UserWarning))
self.assertTrue("semaphore_tracker: process died"
in str(the_warn.message))
else:
Expand Down