Skip to content

gh-90110: Fix the c-analyzer Tool #96731

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ericsnowcurrently merged 26 commits into from
Sep 12, 2022
Merged

gh-90110: Fix the c-analyzer Tool #96731

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
f93e2c6
Add large, ignored files to MAX_SIZES.
ericsnowcurrently Aug 29, 2022
a8bd590
Fixups for Python/thread_pthread.h.
ericsnowcurrently Sep 2, 2022
683d1ba
Add some missing defines.
ericsnowcurrently Sep 7, 2022
dd8b682
Support passing "includes" to preprocess().
ericsnowcurrently Sep 7, 2022
1b822b7
Update parser data.
ericsnowcurrently Sep 7, 2022
42114c0
Fix whitelists.
ericsnowcurrently Sep 7, 2022
342ccee
Stop ignoring cjkcodecs.
ericsnowcurrently Sep 7, 2022
12fc111
Stop ignoring _dbmmodule.c.
ericsnowcurrently Sep 7, 2022
1f82c05
Stop ignoring stringlib.
ericsnowcurrently Sep 7, 2022
6e67f68
Add a TODO.
ericsnowcurrently Sep 7, 2022
5c898c4
Fix perf_trampoline.c.
ericsnowcurrently Sep 7, 2022
b930efa
Stop ignoring hashlib.h.
ericsnowcurrently Sep 7, 2022
c74b308
Fix thread_pthread_stubs.h.
ericsnowcurrently Sep 7, 2022
7296153
Stop ignoring KeccakP-1600-opt64.c.
ericsnowcurrently Sep 7, 2022
9566436
Add a note about maybe-inline-actual.
ericsnowcurrently Sep 8, 2022
f91b6d7
Add c_common.fsutil.match_path_tail().
ericsnowcurrently Sep 8, 2022
28d5cc5
Do not add the current file as an include.
ericsnowcurrently Sep 8, 2022
2fa3d87
Update gcc.preprocess().
ericsnowcurrently Sep 9, 2022
401bd73
Always print the current filename when c_parser.parse_files() fails.
ericsnowcurrently Sep 9, 2022
fc3a5a5
Use a consistent filename variable name.
ericsnowcurrently Sep 9, 2022
917a099
Always use absolute paths.
ericsnowcurrently Sep 9, 2022
13449a9
Stop filtering includes.
ericsnowcurrently Sep 9, 2022
c7050eb
Fix analysis for typeobject.c.
ericsnowcurrently Sep 9, 2022
07a87cb
Ignore pystate.c:initial.
ericsnowcurrently Sep 9, 2022
d1d725e
Fix "samefiles" handling.
ericsnowcurrently Sep 10, 2022
6a0e7fc
Report the correct CWD in verbose output.
ericsnowcurrently Sep 12, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix whitelists.
  • Loading branch information
@ericsnowcurrently
ericsnowcurrently committed Sep 9, 2022
commit 42114c0197d685c58d3ca301d544be44f9d7107f
84 changes: 84 additions & 0 deletions Tools/c-analyzer/cpython/globals-to-fix.tsv
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,6 +130,8 @@ Python/symtable.c - PySTEntry_Type -
# private static builtin types

Objects/setobject.c - _PySetDummy_Type -
Objects/stringlib/unicode_format.h - PyFormatterIter_Type -
Objects/stringlib/unicode_format.h - PyFieldNameIter_Type -
Objects/unicodeobject.c - EncodingMapType -
#Objects/unicodeobject.c - PyFieldNameIter_Type -
#Objects/unicodeobject.c - PyFormatterIter_Type -
Expand Down Expand Up @@ -296,6 +298,69 @@ Objects/setobject.c - _dummy_struct -
Objects/setobject.c - _PySet_Dummy -
Objects/sliceobject.c - _Py_EllipsisObject -

#-----------------------
# statically initialized

# argument clinic
Objects/clinic/odictobject.c.h OrderedDict_fromkeys _kwtuple -
Objects/clinic/odictobject.c.h OrderedDict_setdefault _kwtuple -
Objects/clinic/odictobject.c.h OrderedDict_pop _kwtuple -
Objects/clinic/odictobject.c.h OrderedDict_popitem _kwtuple -
Objects/clinic/odictobject.c.h OrderedDict_move_to_end _kwtuple -
Objects/clinic/funcobject.c.h func_new _kwtuple -
Objects/clinic/longobject.c.h long_new _kwtuple -
Objects/clinic/longobject.c.h int_to_bytes _kwtuple -
Objects/clinic/longobject.c.h int_from_bytes _kwtuple -
Objects/clinic/listobject.c.h list_sort _kwtuple -
Objects/clinic/bytearrayobject.c.h bytearray___init__ _kwtuple -
Objects/clinic/bytearrayobject.c.h bytearray_translate _kwtuple -
Objects/clinic/bytearrayobject.c.h bytearray_split _kwtuple -
Objects/clinic/bytearrayobject.c.h bytearray_rsplit _kwtuple -
Objects/clinic/bytearrayobject.c.h bytearray_decode _kwtuple -
Objects/clinic/bytearrayobject.c.h bytearray_splitlines _kwtuple -
Objects/clinic/bytearrayobject.c.h bytearray_hex _kwtuple -
Objects/clinic/memoryobject.c.h memoryview _kwtuple -
Objects/clinic/memoryobject.c.h memoryview_cast _kwtuple -
Objects/clinic/memoryobject.c.h memoryview_tobytes _kwtuple -
Objects/clinic/memoryobject.c.h memoryview_hex _kwtuple -
Objects/clinic/enumobject.c.h enum_new _kwtuple -
Objects/clinic/structseq.c.h structseq_new _kwtuple -
Objects/clinic/descrobject.c.h mappingproxy_new _kwtuple -
Objects/clinic/descrobject.c.h property_init _kwtuple -
Objects/clinic/codeobject.c.h code_replace _kwtuple -
Objects/clinic/codeobject.c.h code__varname_from_oparg _kwtuple -
Objects/clinic/moduleobject.c.h module___init__ _kwtuple -
Objects/clinic/bytesobject.c.h bytes_split _kwtuple -
Objects/clinic/bytesobject.c.h bytes_rsplit _kwtuple -
Objects/clinic/bytesobject.c.h bytes_translate _kwtuple -
Objects/clinic/bytesobject.c.h bytes_decode _kwtuple -
Objects/clinic/bytesobject.c.h bytes_splitlines _kwtuple -
Objects/clinic/bytesobject.c.h bytes_hex _kwtuple -
Objects/clinic/bytesobject.c.h bytes_new _kwtuple -
Objects/clinic/unicodeobject.c.h unicode_encode _kwtuple -
Objects/clinic/unicodeobject.c.h unicode_expandtabs _kwtuple -
Objects/clinic/unicodeobject.c.h unicode_split _kwtuple -
Objects/clinic/unicodeobject.c.h unicode_rsplit _kwtuple -
Objects/clinic/unicodeobject.c.h unicode_splitlines _kwtuple -
Objects/clinic/unicodeobject.c.h unicode_new _kwtuple -
Objects/clinic/complexobject.c.h complex_new _kwtuple -
Python/clinic/traceback.c.h tb_new _kwtuple -
Python/clinic/_warnings.c.h warnings_warn _kwtuple -
Python/clinic/_warnings.c.h warnings_warn_explicit _kwtuple -
Python/clinic/bltinmodule.c.h builtin___import__ _kwtuple -
Python/clinic/bltinmodule.c.h builtin_compile _kwtuple -
Python/clinic/bltinmodule.c.h builtin_exec _kwtuple -
Python/clinic/bltinmodule.c.h builtin_pow _kwtuple -
Python/clinic/bltinmodule.c.h builtin_print _kwtuple -
Python/clinic/bltinmodule.c.h builtin_round _kwtuple -
Python/clinic/bltinmodule.c.h builtin_sum _kwtuple -
Python/clinic/import.c.h _imp_find_frozen _kwtuple -
Python/clinic/import.c.h _imp_source_hash _kwtuple -
Python/clinic/Python-tokenize.c.h tokenizeriter_new _kwtuple -
Python/clinic/sysmodule.c.h sys_addaudithook _kwtuple -
Python/clinic/sysmodule.c.h sys_set_coroutine_origin_tracking_depth _kwtuple -
Python/clinic/sysmodule.c.h sys_set_int_max_str_digits _kwtuple -

#-----------------------
# cached - initialized once

Expand Down Expand Up @@ -338,6 +403,7 @@ Objects/typeobject.c - slotdefs_initialized -
Objects/unicodeobject.c - bloom_linebreak -
Python/bootstrap_hash.c - _Py_HashSecret_Initialized -
Python/bootstrap_hash.c py_getrandom getrandom_works -
Python/initconfig.c - _Py_global_config_int_max_str_digits -
Python/initconfig.c - Py_DebugFlag -
Python/initconfig.c - Py_UTF8Mode -
Python/initconfig.c - Py_DebugFlag -
Expand Down Expand Up @@ -614,6 +680,24 @@ Modules/_ctypes/_ctypes.c - Union_Type -
Modules/_ctypes/callbacks.c - PyCThunk_Type -
Modules/_ctypes/callproc.c - PyCArg_Type -
Modules/_ctypes/cfield.c - PyCField_Type -
Modules/_ctypes/ctypes.h - PyCArg_Type -
Modules/_ctypes/ctypes.h - PyCArrayType_Type -
Modules/_ctypes/ctypes.h - PyCArray_Type -
Modules/_ctypes/ctypes.h - PyCData_Type -
Modules/_ctypes/ctypes.h - PyCField_Type -
Modules/_ctypes/ctypes.h - PyCFuncPtrType_Type -
Modules/_ctypes/ctypes.h - PyCFuncPtr_Type -
Modules/_ctypes/ctypes.h - PyCPointerType_Type -
Modules/_ctypes/ctypes.h - PyCPointer_Type -
Modules/_ctypes/ctypes.h - PyCSimpleType_Type -
Modules/_ctypes/ctypes.h - PyCStgDict_Type -
Modules/_ctypes/ctypes.h - PyCStructType_Type -
Modules/_ctypes/ctypes.h - PyCThunk_Type -
Modules/_ctypes/ctypes.h - PyExc_ArgError -
Modules/_ctypes/ctypes.h - _ctypes_conversion_encoding -
Modules/_ctypes/ctypes.h - _ctypes_conversion_errors -
Modules/_ctypes/ctypes.h - _ctypes_ptrtype_cache -
Modules/_ctypes/ctypes.h - basespec_string -
Modules/_ctypes/stgdict.c - PyCStgDict_Type -
Modules/_cursesmodule.c - PyCursesWindow_Type -
Modules/_datetimemodule.c - PyDateTime_DateTimeType -
Expand Down
5 changes: 5 additions & 0 deletions Tools/c-analyzer/cpython/ignored.tsv
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -340,6 +340,7 @@ Modules/_xxtestfuzz/fuzzer.c LLVMFuzzerTestOneInput AST_LITERAL_EVAL_INITIALIZED
#-----------------------
# other vars that are actually constant

Include/internal/pycore_blocks_output_buffer.h - BUFFER_BLOCK_SIZE -
Modules/_csv.c - quote_styles -
Modules/_ctypes/cfield.c - ffi_type_double -
Modules/_ctypes/cfield.c - ffi_type_float -
Expand Down Expand Up @@ -371,6 +372,7 @@ Modules/_elementtree.c - ExpatMemoryHandler -
Modules/_io/_iomodule.c - static_types -
Modules/_io/textio.c - encodefuncs -
Modules/_localemodule.c - langinfo_constants -
Modules/_pickle.c - READ_WHOLE_LINE -
Modules/_sqlite/module.c - error_codes -
Modules/_sre/sre.c pattern_repr flag_names -
# XXX I'm pretty sure this is actually constant:
Expand Down Expand Up @@ -404,6 +406,8 @@ Modules/nismodule.c - TIMEOUT -
Modules/nismodule.c - aliases -
Modules/ossaudiodev.c - control_labels -
Modules/ossaudiodev.c - control_names -
Modules/posixmodule.c os_getxattr_impl buffer_sizes -
Modules/posixmodule.c os_listxattr_impl buffer_sizes -
Modules/posixmodule.c - posix_constants_confstr -
Modules/posixmodule.c - posix_constants_pathconf -
Modules/posixmodule.c - posix_constants_sysconf -
Expand Down Expand Up @@ -437,6 +441,7 @@ Parser/parser.c - reserved_keywords -
Parser/parser.c - soft_keywords -
Parser/tokenizer.c - type_comment_prefix -
Python/ast_opt.c fold_unaryop ops -
Python/ceval.c - binary_ops -
Python/codecs.c - Py_hexdigits -
Python/codecs.c - ucnhash_capi -
Python/codecs.c _PyCodecRegistry_Init methods -
Expand Down