Skip to content

[3.10] gh-96641: Do not expose KeyWrapper in _functoolsmodule.c (gh-96642) #96645

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
miss-islington merged 1 commit into from
Sep 7, 2022
Merged

[3.10] gh-96641: Do not expose KeyWrapper in _functoolsmodule.c (gh-96642) #96645

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
gh-96641: Do not expose KeyWrapper in _functoolsmodule.c (gh-96642) 
(cherry picked from commit 2fd7246)

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
  • Loading branch information
@sobolevn @miss-islington
sobolevn authored and miss-islington committed Sep 7, 2022
commit 945b8f79189431afe9eb07dbad5a81592c47f38c
1 change: 1 addition & 0 deletions Misc/NEWS.d/next/Core and Builtins/2022-09-07-13-38-37.gh-issue-96641.wky0Fc.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Do not expose ``KeyWrapper`` in :mod:`_functools`.
5 changes: 2 additions & 3 deletions Modules/_functoolsmodule.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1470,9 +1470,8 @@ _functools_exec(PyObject *module)
if (state->keyobject_type == NULL) {
return -1;
}
if (PyModule_AddType(module, state->keyobject_type) < 0) {
return -1;
}
// keyobject_type is used only internally.
// So we don't expose it in module namespace.

state->lru_list_elem_type = (PyTypeObject *)PyType_FromModuleAndSpec(
module, &lru_list_elem_type_spec, NULL);
Expand Down