Repository navigation
gh-90814: Correct NEWS wording re. optional C11 features - #96309
Merged
Merged
Conversation
The current wording of this entry suggests that CPython won't work if optional compiler features are enabled. That's not the case. The change is that we require C11 rather than C89. Note that PEP 7 does say "Python 3.11 and newer versions use C11 without optional features." It is correct there: that's not a guide for users who compile Python, but for CPython devs who must avoid the features.
encukou
added
docs
mdboom
approved these changes
Aug 26, 2022
mdboom
left a comment
mdboom
left a comment
Contributor
There was a problem hiding this comment.
Agreed -- this is much clearer.
Contributor
|
Thanks @encukou for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11. |
Contributor
|
Sorry @encukou, I had trouble checking out the |
Member
|
Thanks for the better wording :-) PEP 7 says "Python 3.11 and newer versions use C11 without optional features": https://peps.python.org/pep-0007/#c-dialect |
Member
Author
|
Please read the first comment here. |
Member
|
Ah right, the commit message mentions PEP 7 :-) |
Member
|
I mentioned PEP 7 since I didn't know if PEP 7 wording is correct. It seems so :-) |
encukou
added a commit
to encukou/cpython
that referenced
this pull request
Aug 29, 2022
…nGH-96309) The previous wording of this entry suggests that CPython won't work if optional compiler features are enabled. That's not the case. The change is that we require C11 rather than C89. Note that PEP 7 does say "Python 3.11 and newer versions use C11 without optional features." It is correct there: that's not a guide for users who compile Python, but for CPython devs who must avoid the features.
|
GH-96384 is a backport of this pull request to the 3.11 branch. |
encukou
added a commit
that referenced
this pull request
Aug 29, 2022
…H-96384) The previous wording of this entry suggests that CPython won't work if optional compiler features are enabled. That's not the case. The change is that we require C11 rather than C89. Note that PEP 7 does say "Python 3.11 and newer versions use C11 without optional features." It is correct there: that's not a guide for users who compile Python, but for CPython devs who must avoid the features.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current wording of this entry suggests that CPython
won't work if optional compiler features are enabled.
That's not the case. The real change is that we require C11
rather than C89.
Note that PEP-7 says "Python 3.11 and newer versions use C11
without optional features." That is correct: CPython devs
must avoid the features, so that they're not required to build Python.