Skip to content

gh-90110: Update the c-analyzer Tool #96255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ericsnowcurrently merged 12 commits into from
Aug 25, 2022
Merged

gh-90110: Update the c-analyzer Tool #96255

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
a6a3360
Fix an undefined variable.
ericsnowcurrently Aug 24, 2022
e5253e5
Fix a moved variable.
ericsnowcurrently Aug 24, 2022
e9298d6
Treat all _PyArg_Parser as supported.
ericsnowcurrently Aug 24, 2022
7593110
Treat other "immutable" structs as supported.
ericsnowcurrently Aug 24, 2022
0d2db68
Factor out _has_other_supported_type().
ericsnowcurrently Aug 25, 2022
f2c3ec4
Add some ignored vars back in.
ericsnowcurrently Aug 25, 2022
5c585c7
Ignore "mutable" vars with supported types.
ericsnowcurrently Aug 25, 2022
bc9abe8
Marks some globals to fix.
ericsnowcurrently Aug 25, 2022
6947e82
Manually ignore globals that the analyzer should have ignored.
ericsnowcurrently Aug 25, 2022
0d6c58f
Ignore globals that look like a kwlist array.
ericsnowcurrently Aug 25, 2022
531bf22
Add some notes about auto-ignored vars.
ericsnowcurrently Aug 25, 2022
e880092
Do not normalize any variable names.
ericsnowcurrently Aug 25, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Factor out _has_other_supported_type().
  • Loading branch information
@ericsnowcurrently
ericsnowcurrently committed Aug 25, 2022
commit 0d2db68061a74aa04f7f0e4d98b4bf2eb1007774
14 changes: 9 additions & 5 deletions Tools/c-analyzer/cpython/_analyzer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -224,11 +224,7 @@ def _check_typedep(decl, typedecl, types, knowntypes):
# XXX Fail?
return 'typespec (missing)'
elif typedecl is _info.UNKNOWN:
vartype = str(decl.vartype).split()
if vartype[0] == 'struct':
vartype = vartype[1:]
vartype = ''.join(vartype)
if vartype in _OTHER_SUPPORTED_TYPES:
if _has_other_supported_type(decl):
return None
# XXX Is this right?
return 'typespec (unknown)'
Expand All @@ -250,6 +246,14 @@ def _check_typedep(decl, typedecl, types, knowntypes):
raise NotImplementedError(decl)


def _has_other_supported_type(decl):
vartype = str(decl.vartype).split()
if vartype[0] == 'struct':
vartype = vartype[1:]
vartype = ''.join(vartype)
return vartype in _OTHER_SUPPORTED_TYPES


def _check_vartype(decl, typedecl, types, knowntypes):
"""Return failure reason."""
checked = _check_typespec(decl, typedecl, types, knowntypes)
Expand Down