Skip to content

gh-95909: Move PyArg_Parser.kwtuple to PyInterpreterState for Non-Core Cases #95910

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ericsnowcurrently wants to merge 10 commits into from
Closed

gh-95909: Move PyArg_Parser.kwtuple to PyInterpreterState for Non-Core Cases #95910

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
c669d8a
Pass interp to _PyArg_Fini().
ericsnowcurrently Aug 10, 2022
ff06ae5
Use the global empty tuple if applicable.
ericsnowcurrently Aug 10, 2022
4c71fa6
Add get_kwtuple().
ericsnowcurrently Aug 10, 2022
4021368
Add _PyArg_Parser.len.
ericsnowcurrently Aug 10, 2022
2b3d0f7
new_kwtuple() -> init_kwtuple().
ericsnowcurrently Aug 11, 2022
b4a12b0
Move get_kwtuple() up.
ericsnowcurrently Aug 11, 2022
4b5e5eb
Factor out clear_kwtuple().
ericsnowcurrently Aug 11, 2022
eedeaf4
Move non-static kwtuples to PyInterpreterState.
ericsnowcurrently Aug 11, 2022
0400930
Add a global lock.
ericsnowcurrently Aug 11, 2022
7fe21b1
Update the c-analyzer whitelists.
ericsnowcurrently Aug 11, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Factor out clear_kwtuple().
  • Loading branch information
@ericsnowcurrently
ericsnowcurrently committed Aug 11, 2022
commit 4b5e5eb4f5eb4d21251e7185cfe6bb8874469b65
12 changes: 9 additions & 3 deletions Python/getargs.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1990,6 +1990,14 @@ get_kwtuple(struct _PyArg_Parser *parser)
return parser->kwtuple;
}

static void
clear_kwtuple(struct _PyArg_Parser *parser)
{
if (parser->initialized == 1) {
Py_CLEAR(parser->kwtuple);
}
}

static int
parser_init(struct _PyArg_Parser *parser)
{
Expand Down Expand Up @@ -2047,9 +2055,7 @@ parser_init(struct _PyArg_Parser *parser)
static void
parser_clear(struct _PyArg_Parser *parser)
{
if (parser->initialized == 1) {
Py_CLEAR(parser->kwtuple);
}
clear_kwtuple(parser);
}

static PyObject*
Expand Down