Repository navigation
gh-95573: Fix a mistake in asyncio ssl test suppressing all logs - #95687
Merged
Merged
Conversation
ambv
added
needs backport to 3.11
Contributor
|
Actually this doesn't go to 3.10, |
Contributor
|
GH-95699 is a backport of this pull request to the 3.11 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Aug 5, 2022
…gs (pythonGH-95687) (cherry picked from commit e1d68b3) Co-authored-by: Fantix King <fantix.king@gmail.com>
ambv
pushed a commit
that referenced
this pull request
Aug 5, 2022
iritkatriel
pushed a commit
to iritkatriel/cpython
that referenced
this pull request
Aug 11, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was originally introduced here and inherited in the cpython test suite, preventing the root reason of issues like #95573 from being easily seen.
Basically the idea of this filter is to prevent a warning saying
returning true from eof_received() has no effect when using ssl, so we need to check the message instead of the logger name (likelogging.Filterdoes).