Skip to content

gh-87597: Decode subprocess output in text mode when timeout is hit #95579

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
LewisGaul wants to merge 9 commits into
base: main
Choose a base branch
from
Draft

gh-87597: Decode subprocess output in text mode when timeout is hit #95579

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
fa8d19c
Implement handling of unicode decode error from incomplete code bytes
LewisGaul Aug 2, 2022
aecc55b
Add testcase
LewisGaul Aug 2, 2022
4b4b7eb
📜🤖 Added by blurb_it.
blurb-it[bot] Aug 2, 2022
c4b1012
Update Misc/NEWS.d/next/Core and Builtins/2022-08-02-18-12-34.gh-issu…
LewisGaul Aug 2, 2022
a2c7e06
Skip testcase on Windows - after timeout the threads reading output a…
LewisGaul Aug 2, 2022
9d2168e
Test markups
LewisGaul Aug 3, 2022
98bff39
If no output before timeout is hit ensure empty string/bytes is store…
LewisGaul Aug 7, 2022
39393a8
Reduce timeout when not waiting for any output
LewisGaul Aug 7, 2022
34dfe5a
Merge branch 'main' into fix-issue-87597
LewisGaul Aug 15, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Skip testcase on Windows - after timeout the threads reading output a… 
…re left running
  • Loading branch information
@LewisGaul
LewisGaul committed Aug 2, 2022
commit a2c7e068326e16d163f94862579b2f569681c2be
1 change: 1 addition & 0 deletions Lib/test/test_subprocess.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1129,6 +1129,7 @@ def test_universal_newlines_communicate_encodings(self):
stdout, stderr = popen.communicate(input='')
self.assertEqual(stdout, '1\n2\n3\n4')

@unittest.skipIf(mswindows, "behavior currently not supported on Windows")

@gpshead gpshead Sep 30, 2022

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is needed for this to work on Windows?

having inconsistent behavior in the returned stderr/stdout types on Timeout between the two platforms will make people's code difficult.

@zooba zooba Oct 3, 2022

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hah, I didn't even notice this.

I'm guessing this should actually be "platforms that don't default to UTF-8 don't trigger the decoding error", which luckily is easily resolved by explicitly specifying that the encoding should be utf-8.

def test_universal_newlines_timeout(self):
with self.assertRaises(subprocess.TimeoutExpired) as c:
p = subprocess.run(
Expand Down