Skip to content

gh-95335: extract 'struct cfg_builder' from the compiler so that the CFG can be manipulated directly #95107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
iritkatriel merged 11 commits into from
Jul 26, 2022
Merged

gh-95335: extract 'struct cfg_builder' from the compiler so that the CFG can be manipulated directly #95107

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
98b4902
gh-93678: extract 'struct cfg' from the compiler so that the CFG can …
iritkatriel Jul 21, 2022
4bbebf8
add two missing static qualifiers
iritkatriel Jul 21, 2022
7984b09
add entryblock field to cfg struct
iritkatriel Jul 24, 2022
43fa292
remove basicblock_new_b_list_successor and use cfg_new_block instead
iritkatriel Jul 24, 2022
1e7d1df
inline new_basicblock - it's called in onyl one place now and it's no…
iritkatriel Jul 25, 2022
e943cc2
rename cfg --> cfg_builder, entryblock field --> cfg
iritkatriel Jul 25, 2022
f7ba9e8
📜🤖 Added by blurb_it.
blurb-it[bot] Jul 26, 2022
c3e767a
Merge branch 'main' into cfg_struct
iritkatriel Jul 26, 2022
5a6dc5d
cfg --> cfg_entryblock
iritkatriel Jul 26, 2022
3a8436e
remove obsolete comment
iritkatriel Jul 26, 2022
873d34f
pass location by value
iritkatriel Jul 26, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
inline new_basicblock - it's called in onyl one place now and it's no… 
…t safe to call from elsewhere
  • Loading branch information
@iritkatriel
iritkatriel committed Jul 25, 2022
commit 1e7d1df5ef9204869b3a1da236c4d9c623e12356
12 changes: 1 addition & 11 deletions Python/compile.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -843,23 +843,13 @@ compiler_set_qualname(struct compiler *c)
Returns NULL on error.
*/
static basicblock *
new_basicblock()
cfg_new_block(cfg *g)
{
basicblock *b = (basicblock *)PyObject_Calloc(1, sizeof(basicblock));
if (b == NULL) {
PyErr_NoMemory();
return NULL;
}
return b;
}

static basicblock *
cfg_new_block(cfg *g)
{
basicblock *b = new_basicblock();
if (b == NULL) {
return NULL;
}
/* Extend the singly linked list of blocks with new block. */
b->b_list = g->block_list;
g->block_list = b;
Expand Down