Skip to content

gh-94912: deprecate asyncio.iscoroutinefunction when it behaves differently to inspect.iscoroutinefunction #94923

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
graingert wants to merge 10 commits into from
Closed

gh-94912: deprecate asyncio.iscoroutinefunction when it behaves differently to inspect.iscoroutinefunction #94923

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
1a39312
support inspect.iscoroutinefunction in create_autospec(async_def)
graingert Jul 17, 2022
56c6ed4
alias asyncio.iscoroutinefunction to inspect.iscoroutinefunction
graingert Jul 17, 2022
2b837c8
📜🤖 Added by blurb_it.
blurb-it[bot] Jul 17, 2022
aedef3f
test that virtual awaitables are no longer supported in asyncio.creat…
graingert Jul 17, 2022
a4c0767
deprecate asyncio.iscoroutinefunction in favour of inspect.iscoroutin…
graingert Jul 17, 2022
5402f43
avoid internal use of deprecated asyncio.iscoroutinefunction
graingert Jul 17, 2022
d792bf9
Merge branch 'main' into asyncio-iscoroutinefunction
graingert Jul 18, 2022
dafc2ff
restore the _is_coroutine marker for Cython
graingert Jul 18, 2022
f839f14
remove doc reference to asyncio.iscoroutinefunction
graingert Jul 18, 2022
e9d2eb3
only warn when 'asyncio.coroutines._is_coroutine' flag is used
graingert Jul 19, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
only warn when 'asyncio.coroutines._is_coroutine' flag is used
  • Loading branch information
@graingert
graingert committed Jul 19, 2022
commit e9d2eb3aa92f15fe7ad603acdcb0d40e33790f02
11 changes: 8 additions & 3 deletions Lib/asyncio/coroutines.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,9 +20,14 @@ def _is_debug_mode():

def iscoroutinefunction(func):
"""Return True if func is a decorated coroutine function."""
warnings._deprecated("asyncio.iscoroutinefunction", remove=(3, 14))
return (inspect.iscoroutinefunction(func) or
getattr(func, '_is_coroutine', None) is _is_coroutine)
if inspect.iscoroutinefunction(func):
return True

if getattr(func, '_is_coroutine', None) is _is_coroutine:
warnings._deprecated("asyncio.coroutines._is_coroutine", remove=(3, 14))
return True

return False


# Prioritize native coroutine check to speed-up
Expand Down