Skip to content

gh-94731: Revert to C-style casts for _Py_CAST #94782

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
encukou merged 8 commits into from
Jul 14, 2022
Merged

gh-94731: Revert to C-style casts for _Py_CAST #94782

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
f09b8c6
gh-94731: Add a failing test
encukou Jul 12, 2022
3faf13d
gh-94731: Use C-style casts for _Py_CAST, even in C++
encukou Jul 12, 2022
b3b4ec8
Add a blurb
encukou Jul 12, 2022
498e8bb
Also allow the -Wzero-as-null-pointer-constant warning
encukou Jul 12, 2022
b13e464
Workaround for C++ compilers that don't support designated initializers
encukou Jul 13, 2022
c6945f1
Rename the type variable (ipotype was a hold-over from the original r…
encukou Jul 13, 2022
713bf7d
Punt on C++ sanitizing builds for now
encukou Jul 13, 2022
021c03d
Make the skip work if PY_CFLAGS is not set
encukou Jul 13, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Also allow the -Wzero-as-null-pointer-constant warning
  • Loading branch information
@encukou
encukou committed Jul 12, 2022
commit 498e8bbac1c0767b1c02b674a8af20f275d247e5
3 changes: 0 additions & 3 deletions Lib/test/setup_testcppext.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,9 +35,6 @@ def main():
name = '_testcpp11ext'

cppflags = [*CPPFLAGS, f'-std={std}']
if std == 'c++11':
# Warn when using NULL rather than _Py_NULL in static inline functions
cppflags.append('-Wzero-as-null-pointer-constant')

cpp_ext = Extension(
name,
Expand Down
2 changes: 1 addition & 1 deletion Misc/NEWS.d/next/C API/2022-07-12-17-39-32.gh-issue-94731.9CPJNU.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
Python again uses C-style casts for most casting operations when compiled
with C++. This may trigger compiler warnings, if they are enabled with e.g.
``g++ -Wold-style-cast``.
``-Wold-style-cast `` or ``-Wzero-as-null-pointer-constant`` options for ``g++``.