Skip to content

gh-51574: Make tempfile.mkdtemp() always return absolute paths #94612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AlexWaygood merged 12 commits into from
Apr 25, 2023
Merged

gh-51574: Make tempfile.mkdtemp() always return absolute paths #94612

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
2fc9fab
Make tempfile.mkdtemp() always return absolute paths
kj7rrv Jul 6, 2022
2365693
Document change
kj7rrv Jul 6, 2022
ef2dda6
Merge branch 'main' into mkdtemp-absolute
kj7rrv Jul 6, 2022
a9098be
Add test for tempfile.mkdtemp output being absolute
kj7rrv Jul 6, 2022
7a48316
Merge branch 'main' into mkdtemp-absolute
kj7rrv Jul 6, 2022
a65f152
Update Doc/library/tempfile.rst
kj7rrv Jul 7, 2022
ff507d9
Fix test
kj7rrv Jul 7, 2022
8be2bf2
Update Misc/NEWS.d/next/Library/2022-07-06-11-10-37.gh-issue-51574.sv…
kj7rrv Apr 24, 2023
b4e19df
Merge branch 'main' into mkdtemp-absolute
Apr 24, 2023
fd360f4
Merge branch 'main' into mkdtemp-absolute
arhadthedev Apr 25, 2023
9085b35
Minor perf optimisation: only call abspath when necessary
AlexWaygood Apr 25, 2023
8e8967a
Add note to whatsnew
AlexWaygood Apr 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix test
  • Loading branch information
@kj7rrv
kj7rrv committed Jul 7, 2022
commit ff507d9002bb0689ea2e3cfbc80976a49b7a1f96
13 changes: 8 additions & 5 deletions Lib/test/test_tempfile.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -848,11 +848,14 @@ def test_for_tempdir_is_bytes_issue40701_api_warts(self):
finally:
tempfile.tempdir = orig_tempdir

def test_absolute_path(self):
"""Test that the path returned is absolute"""
path = tempfile.mkdtemp(dir=".")
self.assertEqual(os.path.isabs(path), True)
os.rmdir(path)
def test_path_is_absolute(self):
# Test that the path returned by mkdtemp with a relative `dir`
# argument is absolute
try:
path = tempfile.mkdtemp(dir=".")
self.assertTrue(os.path.isabs(path))
finally:
os.rmdir(path)


class TestMktemp(BaseTestCase):
Expand Down