Skip to content

gh-94607: Fix subclassing generics #94610

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Fidget-Spinner merged 12 commits into from
Jul 9, 2022
Merged

gh-94607: Fix subclassing generics #94610

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
c63a4fa
Fix subclassing generics
Fidget-Spinner Jul 6, 2022
be88cf8
📜🤖 Added by blurb_it.
blurb-it[bot] Jul 6, 2022
8eb2051
fix comment
Fidget-Spinner Jul 6, 2022
5cb5c45
Add tests
Fidget-Spinner Jul 6, 2022
92a94a1
Merge branch 'fix_generic_subclasses' of https://github.com/Fidget-Sp…
Fidget-Spinner Jul 6, 2022
a9c3881
use more restrictive checks
Fidget-Spinner Jul 6, 2022
d44dd50
fix comment
Fidget-Spinner Jul 6, 2022
bc475be
explicitly skip, add tests
Fidget-Spinner Jul 7, 2022
35e00d6
Fix C version, add more tests
Fidget-Spinner Jul 7, 2022
4c7f11b
Update 2022-07-06-16-01-08.gh-issue-94607.Q6RYfz.rst
Fidget-Spinner Jul 7, 2022
a2fdbb4
test C version
Fidget-Spinner Jul 8, 2022
246a8b0
Make comments more accurate
Fidget-Spinner Jul 8, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Fix subclassing generics
  • Loading branch information
@Fidget-Spinner
Fidget-Spinner committed Jul 6, 2022
commit c63a4fa7582ceb68978f2c89947f1eaa1dcdfe4a
3 changes: 2 additions & 1 deletion Lib/typing.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -253,7 +253,8 @@ def _collect_parameters(args):
if hasattr(t, '__typing_subst__'):
if t not in parameters:
parameters.append(t)
else:
# We need to avoid bare Python types as those aren't really generic.
elif not type(t) is type:
for x in getattr(t, '__parameters__', ()):
if x not in parameters:
parameters.append(x)
Expand Down