Skip to content

GH-93896: always set event loop in asyncio.run and IsolatedAsyncioTestCase #94593

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pablogsal merged 5 commits into from
Jul 6, 2022
Merged

GH-93896: always set event loop in asyncio.run and IsolatedAsyncioTestCase #94593

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
a67cc6f
always set event loop
kumaraditya303 Jul 6, 2022
9576a91
📜🤖 Added by blurb_it.
blurb-it[bot] Jul 6, 2022
f3c1caf
wip
kumaraditya303 Jul 6, 2022
d01fd01
add a test
kumaraditya303 Jul 6, 2022
16be2ec
fix import
kumaraditya303 Jul 6, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
add a test
  • Loading branch information
@kumaraditya303
kumaraditya303 authored Jul 6, 2022
commit d01fd0137dbf914d4548b8a27f5f2c8d1d4addac
13 changes: 13 additions & 0 deletions Lib/test/test_asyncio/test_runners.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
import _thread
import asyncio
import contextvars
from email import policy
import re
import signal
import threading
Expand Down Expand Up @@ -198,6 +199,18 @@ async def main():
self.assertIsNone(spinner.ag_frame)
self.assertFalse(spinner.ag_running)

def test_asyncio_run_set_event_loop(self):
#See https://github.com/python/cpython/issues/93896

async def main():
await asyncio.sleep(0)
return 42

policy = asyncio.get_event_loop_policy()
policy.set_event_loop = mock.Mock()
asyncio.run(main())
self.assertTrue(policy.set_event_loop.called)


class RunnerTests(BaseTest):

Expand Down