Skip to content

gh-89546: Clean up PyType_FromMetaclass #93686

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
miss-islington merged 19 commits into from
Jun 14, 2022
Merged

gh-89546: Clean up PyType_FromMetaclass #93686

Changes from 1 commit
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
d43d5ca
Raise invalid slot exceptions early
encukou May 31, 2022
5145034
Switch to `switch` for the slots
encukou May 31, 2022
87b28aa
Allocate & copy the docstring early
encukou Jun 1, 2022
9fb6b11
Prepare the type names early
encukou Jun 1, 2022
7fd0c6d
Move offset setting to before PyType_Ready
encukou Jun 1, 2022
06fe302
Add comment on preparing special slots
encukou Jun 1, 2022
8bb54f8
Comment that we don't want to call Python code while a type is half-b…
encukou Jun 1, 2022
6c25cfc
Add comment on the function's refcounting strategy
encukou Jun 1, 2022
7edb478
Check that base & offsets fit in the basicsize
encukou Jun 1, 2022
2075958
Add blurb for the new check
encukou Jun 10, 2022
763ea2d
Move variable declarations out of `switch` cases
encukou Jun 10, 2022
5ca1502
Fix ReST syntax (*sigh*)
encukou Jun 10, 2022
5b18552
Downcast to int to avoid a warning
encukou Jun 13, 2022
34edc2a
Reflow check_basicsize_includes_size_and_offsets to conform to style …
encukou Jun 13, 2022
e45f77f
Reword error messages to say "offset is out of bounds"
encukou Jun 13, 2022
9713fb4
Move modname down to improve scoping
encukou Jun 13, 2022
a997413
Move variables to smaller scopes
encukou Jun 13, 2022
b197bb5
Merge main branch to resolve conflicts
encukou Jun 13, 2022
f53d86c
One more PEP 7 nit!
encukou Jun 14, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Allocate & copy the docstring early
  • Loading branch information
@encukou
encukou committed Jun 10, 2022
commit 87b28aa319e0ee2b0c925e4efdc21400a2b9477b
55 changes: 30 additions & 25 deletions Objects/typeobject.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3406,6 +3406,7 @@ PyType_FromMetaclass(PyTypeObject *metaclass, PyObject *module,
PyObject *modname = NULL;
Comment thread
encukou marked this conversation as resolved.
Outdated
PyTypeObject *type;
PyObject *bases = NULL;
char *tp_doc = NULL;
int r;

const PyType_Slot *slot;
Expand Down Expand Up @@ -3451,6 +3452,29 @@ PyType_FromMetaclass(PyTypeObject *metaclass, PyObject *module,
}
}
break;
case Py_tp_doc:
Comment thread
erlend-aasland marked this conversation as resolved.
/* For the docstring slot, which usually points to a static string
literal, we need to make a copy */
if (tp_doc != NULL) {
PyErr_SetString(
PyExc_SystemError,
"Multiple Py_tp_doc slots are not supported.");
return NULL;
}
if (slot->pfunc == NULL) {
PyObject_Free(tp_doc);
tp_doc = NULL;
}
else {
size_t len = strlen(slot->pfunc)+1;
tp_doc = PyObject_Malloc(len);
if (tp_doc == NULL) {
PyErr_NoMemory();
goto finally;
}
memcpy(tp_doc, slot->pfunc, len);
}
break;
}
}

Expand Down Expand Up @@ -3555,43 +3579,23 @@ PyType_FromMetaclass(PyTypeObject *metaclass, PyObject *module,
type->tp_bases = bases;
bases = NULL; // We give our reference to bases to the type

type->tp_doc = tp_doc;
tp_doc = NULL; // Give ownership of the allocated memory to the type

/* Copy the sizes */
type->tp_basicsize = spec->basicsize;
type->tp_itemsize = spec->itemsize;

for (slot = spec->slots; slot->slot; slot++) {
size_t len;
switch (slot->slot) {
case Py_tp_base:
case Py_tp_bases:
/* Processed above */
break;
case Py_tp_doc:
/* For the docstring slot, which usually points to a static string
literal, we need to make a copy */
if (type->tp_doc != NULL) {
PyErr_SetString(
PyExc_SystemError,
"Multiple Py_tp_doc slots are not supported.");
return NULL;
}
if (slot->pfunc == NULL) {
type->tp_doc = NULL;
break;
}
len = strlen(slot->pfunc)+1;
char *tp_doc = PyObject_Malloc(len);
if (tp_doc == NULL) {
type->tp_doc = NULL;
PyErr_NoMemory();
goto finally;
}
memcpy(tp_doc, slot->pfunc, len);
type->tp_doc = tp_doc;
/* Processed above */
break;
case Py_tp_members:
/* Move the slots to the heap type itself */
len = Py_TYPE(type)->tp_itemsize * nmembers;
size_t len = Py_TYPE(type)->tp_itemsize * nmembers;
memcpy(_PyHeapType_GET_MEMBERS(res), slot->pfunc, len);
type->tp_members = _PyHeapType_GET_MEMBERS(res);
break;
Expand Down Expand Up @@ -3687,6 +3691,7 @@ PyType_FromMetaclass(PyTypeObject *metaclass, PyObject *module,
}
Py_XDECREF(bases);
Py_XDECREF(modname);
PyObject_Free(tp_doc);
return (PyObject*)res;
}

Expand Down