Repository navigation
Conversation
Cython makes the assumption that PyCode_Type.tp_basicsize equals to sizeof(PyCodeObject). This assumption is no longer true since the commit 2bde682. Restore tp_basicsize until the PyCodeObject structure can use a C99 flexible array of size zero with the syntax "char co_code_adaptive[]".
encukou
requested changes
Jun 7, 2022
encukou
left a comment
encukou
left a comment
Member
There was a problem hiding this comment.
There is no reason to waste one _Py_CODEUNIT of memory per code object. Cython should update its check.
|
When you're done making the requested changes, leave the comment: |
Member
Author
|
See #93585 (comment) for the rationale for this change. |
Member
Author
Member
|
I'll close this PR, see the issue for rationale. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cython makes the assumption that PyCode_Type.tp_basicsize equals to
sizeof(PyCodeObject). This assumption is no longer true since the
commit 2bde682. Restore tp_basicsize
until the PyCodeObject structure can use a C99 flexible array of size
zero with the syntax "char co_code_adaptive[]".