gh-92597: Ensure that AST nodes without explicit end positions can be…

… compiled (GH-93359) (cherry picked from commit 705eaec) Co-authored-by: Pablo Galindo Salgado <Pablogsal@gmail.com>
miss-islington · May 31, 2022 · May 31, 2022 · May 31, 2022 · a3156c6d570f841c7a17f5aaaa9bf319e6d3cdc8
commit a3156c6d570f841c7a17f5aaaa9bf319e6d3cdc8
diff --git a/Lib/test/test_ast.py b/Lib/test/test_ast.py
@@ -362,6 +362,14 @@ def test_invalid_position_information(self):
                 with self.assertRaises(ValueError):
                     compile(tree, '<string>', 'exec')
 
+    def test_compilation_of_ast_nodes_with_default_end_position_values(self):
+        tree = ast.Module(body=[
+            ast.Import(names=[ast.alias(name='builtins', lineno=1, col_offset=0)], lineno=1, col_offset=0), 
+            ast.Import(names=[ast.alias(name='traceback', lineno=0, col_offset=0)], lineno=0, col_offset=1)
+        ], type_ignores=[])
+
+        # Check that compilation doesn't crash. Note: this may crash explicitly only on debug mode.
+        compile(tree, "<string>", "exec")
 
     def test_slice(self):
         slc = ast.parse("x[::]").body[0].value.slice

diff --git a/Misc/NEWS.d/next/Core and Builtins/2022-05-30-19-00-38.gh-issue-93359.zXV3A0.rst b/Misc/NEWS.d/next/Core and Builtins/2022-05-30-19-00-38.gh-issue-93359.zXV3A0.rst
@@ -0,0 +1,2 @@
+Ensure that custom :mod:`ast` nodes without explicit end positions can be
+compiled. Patch by Pablo Galindo.
@@ -488,6 +488,12 @@ def visitProduct(self, prod, name):
 
 
 class Obj2ModVisitor(PickleVisitor):
+
+    attribute_special_defaults = {
+        "end_lineno": "lineno",
+        "end_col_offset": "col_offset",
+    }
+
     @contextmanager
     def recursive_call(self, node, level):
         self.emit('if (_Py_EnterRecursiveCall(" while traversing \'%s\' node")) {' % node, level, reflow=False)
@@ -637,7 +643,13 @@ def visitField(self, field, name, sum=None, prod=None, depth=0):
             self.emit("if (tmp == NULL || tmp == Py_None) {", depth)
             self.emit("Py_CLEAR(tmp);", depth+1)
             if self.isNumeric(field):
-                self.emit("%s = 0;" % field.name, depth+1)
+                if field.name in self.attribute_special_defaults:
+                    self.emit(
+                        "%s = %s;" % (field.name, self.attribute_special_defaults[field.name]),
+                        depth+1,
+                    )
+                else:
+                    self.emit("%s = 0;" % field.name, depth+1)
             elif not self.isSimpleType(field):
                 self.emit("%s = NULL;" % field.name, depth+1)
             else:

diff --git a/Python/Python-ast.c b/Python/Python-ast.c
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1,2 @@
		Ensure that custom :mod:`ast` nodes without explicit end positions can be
		compiled. Patch by Pablo Galindo.