Skip to content

gh-93357: Lay the foundation for further work in asyncio.test_streams: port server cases to IsolatedAsyncioTestCase #93369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gvanrossum merged 11 commits into from
Oct 4, 2022
Merged

gh-93357: Lay the foundation for further work in asyncio.test_streams: port server cases to IsolatedAsyncioTestCase #93369

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
a052bf7
Port server cases to IsolatedAsyncioTestCase
arhadthedev May 31, 2022
1f8977b
Add forgotten setUp and tearDown into StreamTests2
arhadthedev May 31, 2022
3205970
Use subtests to localize errors
arhadthedev May 31, 2022
9f32482
Fix a wrongly used address
arhadthedev May 31, 2022
e41c7ca
Fix another typo
arhadthedev May 31, 2022
35e4f26
Remove manual server starting
arhadthedev May 31, 2022
92e30e5
Address a review of Serhiy Storchaka
arhadthedev Jun 1, 2022
e706f2c
Merge branch 'main' into teststreams-utilsTestCase-servers
arhadthedev Jul 11, 2022
690e451
Merge branch 'main' into teststreams-utilsTestCase-servers
arhadthedev Aug 1, 2022
cabc398
Merge branch 'main' into teststreams-utilsTestCase-servers
gvanrossum Sep 27, 2022
dcc10dd
Remove a What's New entry as proposed by Nikita Sobolev
arhadthedev Oct 2, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix a wrongly used address
  • Loading branch information
@arhadthedev
arhadthedev committed May 31, 2022
commit 9f32482796c85955c2e074e7ea205d22505b3b4d
3 changes: 2 additions & 1 deletion Lib/test/test_asyncio/test_streams.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -605,7 +605,8 @@ async def handle_client_callback(client_reader, client_writer):
handle_client_callback,
host=socket_helper.HOSTv4
)
address, port = server.sockets[0].getsockname()
addr = server.sockets[0].getsockname()
reader, writer = await asyncio.open_connection(*addr)
msg = await client(addr)
server.close()
await server.wait_closed()
Expand Down