Skip to content

gh-92886: fixed tests that were breaking while running with basic optimizations enabled (-O, assertions off) #93174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jackh-ncl wants to merge 14 commits into from
Closed

gh-92886: fixed tests that were breaking while running with basic optimizations enabled (-O, assertions off) #93174

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
0f8ae9b
Fixed clinic and dis test
May 24, 2022
6afde94
Fixed coroutines test
May 24, 2022
0d71b7a
Skipped test_imaplib.py ThreadedNetworkedTests.test_dump_ur if not in…
May 24, 2022
f515d9f
fix test_multiprocessing_forkserver.py test
May 24, 2022
ff6b191
Using self.assertEqual in test_coroutines.py
May 24, 2022
3926165
Brining other assertions in line in _test_multiprocessing.py
May 24, 2022
47a0eb1
Fixed test_py_compile.py broken test
May 24, 2022
1dcb59e
Fixed test_sys_settrace.py tests
May 24, 2022
de758bb
Fixed handlers.py tests
May 24, 2022
afb2620
Fixed other test_py_compile.py test
May 24, 2022
6edf183
Fixed test_zipimport.py test
May 24, 2022
932449f
📜🤖 Added by blurb_it.
blurb-it[bot] May 24, 2022
84563b0
Fix condition in handlers.py
May 24, 2022
3346ca3
Merge branch '92886' of github.com:jackh-ncl/cpython into 92886
May 24, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fixed other test_py_compile.py test
  • Loading branch information
Jack Hindmarch
Jack Hindmarch committed May 24, 2022
commit afb2620d8ba8b23f631fd2ea8e47b0f8b83a261a
4 changes: 2 additions & 2 deletions Lib/test/test_py_compile.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -235,12 +235,12 @@ def pycompilecmd(self, *args, **kwargs):
# assert_python_* helpers don't return proc object. We'll just use
# subprocess.run() instead of spawn_python() and its friends to test
# stdin support of the CLI.
opts = '-m' if __debug__ else '-Om'

@jackh-ncl jackh-ncl May 24, 2022

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure how this actually fixed things, but it seems to have done the trick 🤷‍♂️

if args and args[0] == '-' and 'input' in kwargs:
opts = '-m' if __debug__ else '-Om'
return subprocess.run([sys.executable, opts, 'py_compile', '-'],
input=kwargs['input'].encode(),
capture_output=True)
return script_helper.assert_python_ok('-m', 'py_compile', *args, **kwargs)
return script_helper.assert_python_ok(opts, 'py_compile', *args, **kwargs)

def pycompilecmd_failure(self, *args):
return script_helper.assert_python_failure('-m', 'py_compile', *args)
Expand Down