Repository navigation
[3.10] gh-93108: Bump sphinx to fix rendering issue. - #93159
Merged
Merged
Conversation
Bug was visible on SysLogHandler:
bad: SysLogHandler(address='localhost', SYSLOG_UDP_PORT, ...
good: SysLogHandler(address=('localhost', SYSLOG_UDP_PORT), ...
DanielNoord
suggested changes
May 24, 2022
DanielNoord
left a comment
DanielNoord
left a comment
Contributor
There was a problem hiding this comment.
The comments in this file also mention 3.2.1 and should probably be updated.
The 3.9 branch also refers to the actual pinned version of Sphinx in its comments, see https://github.com/python/cpython/blob/3.9/Doc/requirements.txt.
Member
Author
|
@DanielNoord you're right, I updated the surrouding comments. |
DanielNoord
approved these changes
May 24, 2022
AA-Turner
approved these changes
May 27, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug was visible on SysLogHandler in Python 3.10 only (3.9 uses an older Sphinx version without the issue, 3.11 uses a newer Sphinx version without the issue).
bad:
SysLogHandler(address='localhost', SYSLOG_UDP_PORT, ...good:
SysLogHandler(address=('localhost', SYSLOG_UDP_PORT), ...So this commit only lives on 3.10, hope that's ok! @pablogsal what do you think?