Repository navigation
gh-92434: Silence a compiler warning in _xxsubinterpretersmodule.c for 32bit version - #93091
Merged
Merged
Conversation
corona10
approved these changes
May 25, 2022
corona10
left a comment
corona10
left a comment
Member
There was a problem hiding this comment.
Since PyObject *ids = PyList_New((Py_ssize_t)count); is already casted,
type casting for i will not be a problem.
lgtm
Contributor
Author
|
Thanks! |
2 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, 32bit version of
channel_list_all()gets apossible loss of datawarning on MSVC.#92434