Skip to content

gh-92592: Allow logging filters to return a LogRecord. (GH-92591) #92591

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vsajip merged 18 commits into from
Jun 7, 2022
Merged

gh-92592: Allow logging filters to return a LogRecord. (GH-92591) #92591

Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
3aeeba6
allow logging filters to return a LogRecord
adriangb May 10, 2022
1e4d27f
edit docstring
adriangb May 10, 2022
b526a35
remove unecessary __bool__ impl
adriangb May 10, 2022
f1ea183
edit docs
adriangb May 10, 2022
19561d3
Add docs and blurb
adriangb May 10, 2022
14e704d
Merge branch 'main' into logging-filters
adriangb May 10, 2022
4d34540
fix rst
adriangb May 10, 2022
a69e76a
touch up wording
adriangb May 10, 2022
67453f6
add test for filters on loggers
adriangb May 10, 2022
b1e1084
push straggler change
adriangb May 10, 2022
f72c594
Merge branch 'main' into logging-filters
adriangb May 10, 2022
225329f
pr feedback
adriangb May 10, 2022
735d78a
Merge branch 'logging-filters' of https://github.com/adriangb/cpython…
adriangb May 10, 2022
5e54c77
Merge branch 'main' into logging-filters
adriangb May 10, 2022
f52e404
fix whitespace
adriangb May 10, 2022
46e2f7f
fix docs as per pr feedback
adriangb May 10, 2022
7a0f470
Update logging-cookbook.rst
vsajip Jun 7, 2022
643551d
Update logging.rst
vsajip Jun 7, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
touch up wording
  • Loading branch information
@adriangb
adriangb committed May 10, 2022
commit a69e76a474c59adc7c7b0c02d615df762a304fab
4 changes: 2 additions & 2 deletions Doc/library/logging.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -664,8 +664,8 @@ empty string, all events are passed.

Is the specified record to be logged? Returns zero for no, nonzero for

@vsajip vsajip May 10, 2022

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After the change, this should be `a 'falsy' value for no, and a 'truthy' value for yes.

yes. Filters can also modify log records in-place or return a completely

@vsajip vsajip May 10, 2022

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also -> either

different log-record which will replace the original log record without
modifying it.
different record instance which will replace the original
log record without modifying it.

@vsajip vsajip May 10, 2022

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the without modifying it should be replaced by in any future processing of the event.


Note that filters attached to handlers are consulted before an event is
emitted by the handler, whereas filters attached to loggers are consulted
Expand Down