Skip to content

gh-92417: fractions, decimal: Improve docs for alternative constructor methods #92421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ambv merged 10 commits into from
May 19, 2022
Merged

gh-92417: fractions, decimal: Improve docs for alternative constructor methods #92421

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
453bc8c
gh-92417: `fractions` docs: remove references to Python <3.2
AlexWaygood May 7, 2022
eb5a0ac
Address review
AlexWaygood May 8, 2022
ac23bec
reST
AlexWaygood May 8, 2022
20399c3
Address review 2
AlexWaygood May 8, 2022
f519d0a
More doctest
AlexWaygood May 8, 2022
e023dc6
Use longform representation, not hex representation
AlexWaygood May 9, 2022
8f537ea
Add notes that these are legacy methods
AlexWaygood May 9, 2022
4435772
I can write in full sentences
AlexWaygood May 9, 2022
4a8d55e
Revert addition of notes that these are legacy methods
AlexWaygood May 9, 2022
bf19119
Start again
AlexWaygood May 10, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Address review 2
  • Loading branch information
@AlexWaygood
AlexWaygood committed May 8, 2022
commit 20399c34689175201657647da236d430700cbc74
3 changes: 2 additions & 1 deletion Doc/library/decimal.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -585,7 +585,8 @@ Decimal objects

.. classmethod:: from_float(f)

Alternative constructor that only accepts instances of :class:`float`.
Alternative constructor that only accepts instances of :class:`float` or
Comment thread
AlexWaygood marked this conversation as resolved.
:class:`int`.

.. versionadded:: 3.1

Expand Down
4 changes: 2 additions & 2 deletions Doc/library/fractions.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,12 +117,12 @@ another rational number, or from a string.
.. classmethod:: from_float(flt)

Alternative constructor which only accepts instances of
:class:`~numbers.Integral` or :class:`float`.
:class:`float` or :class:`numbers.Integral`.

.. classmethod:: from_decimal(dec)

Alternative constructor which only accepts instances of
:class:`decimal.Decimal`.
:class:`decimal.Decimal` or :class:`numbers.Integral`.

.. method:: limit_denominator(max_denominator=1000000)

Expand Down