Skip to content

gh-92261: Disallow iteration of Union (and other _SpecialForms) #92262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
serhiy-storchaka merged 10 commits into from
May 8, 2022
Merged

gh-92261: Disallow iteration of Union (and other _SpecialForms) #92262

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
83ba140
Disallow iteration of Union
mrahtz May 3, 2022
9cb69ca
📜🤖 Added by blurb_it.
blurb-it[bot] May 3, 2022
42b2a56
Add test for isinstance(Iterable)
mrahtz May 7, 2022
6d6d4ff
Switch to __iter__ = None
mrahtz May 7, 2022
207a0f6
Test the specific error message
mrahtz May 7, 2022
70d5c09
Add tests for and fix iteration of Any, List, Callable, Tuple, and An…
mrahtz May 7, 2022
5cd84fc
Merge branch 'main' into disallow-union-iteration
mrahtz May 7, 2022
a9eaa18
Make the error message that we test for less specific
mrahtz May 7, 2022
b82c9e0
Add tests for list(list) and list(tuple)
mrahtz May 7, 2022
64f22fb
Use existing import of Iterable
mrahtz May 7, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add tests for list(list) and list(tuple)
  • Loading branch information
@mrahtz
mrahtz committed May 7, 2022
commit b82c9e0e9dbd3f6a372bdac31dddaf73b9014f01
21 changes: 21 additions & 0 deletions Lib/test/test_genericalias.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
"""Tests for C-implemented GenericAlias."""

import collections
Comment thread
mrahtz marked this conversation as resolved.
Outdated
import unittest
import pickle
import copy
Expand Down Expand Up @@ -487,5 +488,25 @@ def test_del_iter(self):
del iter_x


class TypeIterationTests(unittest.TestCase):
_UNITERABLE_TYPES = (list, tuple)

def test_cannot_iterate(self):
for test_type in self._UNITERABLE_TYPES:
with self.subTest(type=test_type):
expected_error_regex = "object is not iterable"
with self.assertRaisesRegex(TypeError, expected_error_regex):
iter(test_type)
with self.assertRaisesRegex(TypeError, expected_error_regex):
list(test_type)
with self.assertRaisesRegex(TypeError, expected_error_regex):
for _ in test_type:
pass

def test_is_not_instance_of_iterable(self):
for type_to_test in self._UNITERABLE_TYPES:
self.assertNotIsInstance(type_to_test, collections.abc.Iterable)


if __name__ == "__main__":
unittest.main()