Repository navigation
Conversation
encukou
approved these changes
Feb 12, 2024
encukou
left a comment
encukou
left a comment
Member
There was a problem hiding this comment.
LGTM!
Let's merge after alpha 4 is cut, so if something's wrong we don't block the release process.
Contributor
setup.py was removed from our code base a couple of releases ago. This patch will no longer apply to |
Contributor
Author
|
Ah, yes - it's still necessary in Python 3.11, but I don't think such a change can be backported all the way there. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Curses won't compile on Solaris due to several missing defines and include path.
The same/similar patch is being used in other Solarises as well:
Oracle Solaris
OmniOS
OpenIndiana
Fixes part of #91962.