Skip to content

gh-91520: Rewrite imghdr inlining for clarity and completeness #91521

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
warsaw merged 5 commits into from
Apr 15, 2022
Merged

gh-91520: Rewrite imghdr inlining for clarity and completeness #91521

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
e2d4aa6
Rewrite imghdr inlining for clarity and completeness
warsaw Apr 14, 2022
6bb9ffe
See https://github.com/python/cpython/pull/91461#discussion_r850313336
warsaw Apr 14, 2022
7b7365c
Remove the mention of the deprecated imghdr module
warsaw Apr 14, 2022
79e0479
Use underscore names for the rules consistently
warsaw Apr 14, 2022
0bb942c
Update Lib/email/mime/image.py
warsaw Apr 14, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Update Lib/email/mime/image.py 
I like it, thanks.

Co-authored-by: Oleg Iarygin <dralife@yandex.ru>
  • Loading branch information
@warsaw @arhadthedev
warsaw and arhadthedev authored Apr 14, 2022
commit 0bb942c077da08cbeaaf84d8cdeea692a28eca87
4 changes: 2 additions & 2 deletions Lib/email/mime/image.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,9 +34,9 @@ def __init__(self, _imagedata, _subtype=None,
constructor, which turns them into parameters on the Content-Type
header.
"""
_subtype = _what(_imagedata) if _subtype is None else _subtype
if _subtype is None:
if (_subtype := _what(_imagedata)) is None:
raise TypeError('Could not guess image MIME subtype')
raise TypeError('Could not guess image MIME subtype')
MIMENonMultipart.__init__(self, 'image', _subtype, policy=policy,
**_params)
self.set_payload(_imagedata)
Expand Down