Skip to content

[2.7] bpo-34457: Python/ast.c: Add missing NULL check to alias_for_im… #8858

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
serhiy-storchaka merged 1 commit into from
Aug 22, 2018
Merged

[2.7] bpo-34457: Python/ast.c: Add missing NULL check to alias_for_im… #8858

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
[2.7] bpo-34457: Python/ast.c: Add missing NULL check to alias_for_im… 
…port_name(). (GH-8852)

Reported by Svace static analyzer..
(cherry picked from commit 28853a2)

Co-authored-by: Alexey Izbyshev <izbyshev@ispras.ru>
  • Loading branch information
Alexey Izbyshev
Alexey Izbyshev committed Aug 22, 2018
commit 3b11234ec7eb3c6c881aa6365a85695d0ece7b49
2 changes: 2 additions & 0 deletions Python/ast.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2520,6 +2520,8 @@ alias_for_import_name(struct compiling *c, const node *n, int store)
break;
case STAR:
str = PyString_InternFromString("*");
if (!str)

@eamanu eamanu Aug 22, 2018

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In which case the if sentence could fail?

@izbyshev izbyshev Aug 22, 2018

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In an unlikely case of one-character-string cache miss combined with memory allocation failure.

return NULL;
PyArena_AddPyObject(c->c_arena, str);
return alias(str, NULL, c->c_arena);
default:
Expand Down