Skip to content

bpo-34423: Fix check for overflow when casting from a double to integral types. #8802

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
enedil wants to merge 5 commits into from
Closed

bpo-34423: Fix check for overflow when casting from a double to integral types. #8802

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
c05d58d
bpo-32367: Fix check for overflow when casting from a double to integ…
enedil Aug 17, 2018
58b69f0
ACKS and blurb update
enedil Aug 17, 2018
f5a7b94
Bound checks for `time.sleep`
enedil Aug 21, 2018
cc0bcda
Test update
enedil Aug 21, 2018
4e2c8b8
Revert typo
enedil Aug 21, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Test update
  • Loading branch information
@enedil
enedil authored Aug 21, 2018
commit cc0bcdaf991506b07b050fb4e3eab1cfed0ccd25
5 changes: 3 additions & 2 deletions Lib/test/test_time.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,7 +160,7 @@ def test_conversions(self):
def test_sleep(self):
self.assertRaises(ValueError, time.sleep, -2)
self.assertRaises(ValueError, time.sleep, -1)
self.assertRaises(OverflowError, time.sleep(2**63 / 10**9))
self.assertRaises(OverflowError, time.sleep, 2**63 / SEC_TO_NS)
time.sleep(1.2)

def test_strftime(self):
Expand Down Expand Up @@ -918,7 +918,8 @@ class TestCPyTime(CPyTimeTestCase, unittest.TestCase):
Test the C _PyTime_t API.
"""
# _PyTime_t is a 64-bit signed integer
OVERFLOW_SECONDS = math.ceil((2**63 + 1) / SEC_TO_NS)
OVERFLOW_SECONDS = math.ceil((
+ 1) / SEC_TO_NS)

@asottile asottile Aug 21, 2018

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unintentional change?


def test_FromSeconds(self):
from _testcapi import PyTime_FromSeconds
Expand Down