Skip to content

bpo-34384: Fix os.readlink() on Windows #8740

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
berkerpeksag merged 12 commits into from
Aug 15, 2018
Merged

bpo-34384: Fix os.readlink() on Windows #8740

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
7a94c3c
bpo-34384: Fix os.readlink() on Windows
berkerpeksag Aug 12, 2018
618243b
add news blurb
berkerpeksag Aug 12, 2018
35bb6b6
fix build
berkerpeksag Aug 12, 2018
b834795
add some debug prints
berkerpeksag Aug 12, 2018
980b9c4
use FakePath
berkerpeksag Aug 12, 2018
4c8b97e
increase test coverage
berkerpeksag Aug 12, 2018
09c4335
skip bytes tests on Windows
berkerpeksag Aug 13, 2018
3b51dda
try to implement bytes support on Windows
berkerpeksag Aug 13, 2018
eb30636
document new feature
berkerpeksag Aug 13, 2018
d42c9b5
merge posix and windows implementations
berkerpeksag Aug 14, 2018
7ccd0ce
adjust news entry
berkerpeksag Aug 14, 2018
f3e6e2f
address review comments
berkerpeksag Aug 14, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
add some debug prints
  • Loading branch information
@berkerpeksag
berkerpeksag committed Aug 12, 2018
commit b834795619e3567b65f2b98b30279e0cf3f63d3f
6 changes: 6 additions & 0 deletions Lib/test/test_os.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2082,6 +2082,12 @@ def test_readlink_pathlike(self):
import pathlib
os.symlink(self.filelink_target, self.filelink)
filelink = pathlib.Path(self.filelink)

@serhiy-storchaka serhiy-storchaka Aug 12, 2018

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FakePath is used for testing general support of the path protocol, not tied to pathlib.

print()
print('Debug prints:')
print('filelink:', filelink)
print('readlink:', os.readlink(filelink))
print('target:', self.filelink_target)
print()
self.assertEqual(os.readlink(filelink), self.filelink_target)

def _create_missing_dir_link(self):
Expand Down