Skip to content

bpo-33873: Backport regrtest from master to 3.7 #7935

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vstinner merged 3 commits into from
Jun 26, 2018
Merged

bpo-33873: Backport regrtest from master to 3.7 #7935

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
438cb0d
bpo-33718: regrtest: use format_duration() to display failed tests (G…
vstinner Jun 14, 2018
9e54695
bpo-33873: regrtest: Add warning on -R 1:3 (GH-7736)
pablogsal Jun 16, 2018
62b588e
bpo-33873: Fix bug in `runtest.py` and add checks for invalid `-R` pa…
pablogsal Jun 26, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
bpo-33873: regrtest: Add warning on -R 1:3 (GH-7736) 
regrtest: Add warning when using less than 3 warmup runs like -R 1:3.
(cherry picked from commit cac4fef)
  • Loading branch information
@pablogsal @vstinner
pablogsal authored and vstinner committed Jun 26, 2018
commit 9e54695b4ef776299bec45a1e6db9e48dee1a126
7 changes: 7 additions & 0 deletions Lib/test/libregrtest/main.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -462,6 +462,13 @@ def run_tests(self):
or self.tests or self.ns.args)):
self.display_header()

if self.ns.huntrleaks:
warmup, repetitions, _ = self.ns.huntrleaks
if warmup < 3:
msg = ("WARNING: Running tests with --huntrleaks/-R and less than "
"3 warmup repetitions can give false positives!")
print(msg, file=sys.stdout, flush=True)

if self.ns.randomize:
print("Using random seed", self.ns.random_seed)

Expand Down