Skip to content

[3.6] bpo-33951: IDLE test_configdialog: call page.update in setUpClass (GH-7892) #7897

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
miss-islington merged 1 commit into from
Jun 24, 2018
Merged

[3.6] bpo-33951: IDLE test_configdialog: call page.update in setUpClass (GH-7892) #7897

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
bpo-33951: IDLE test_configdialog: call page.update in setUpClass (GH… 
…-7892)

This avoids a failure in at least one case when running only a single
test method rather than all tests in the module.

The issue came up when testing the following on Windows 10 Pro 64-bit:
HighPageTest.test_highlight_target_text_mouse
(cherry picked from commit 2af9f5d)

Co-authored-by: Tal Einat <taleinat+github@gmail.com>
  • Loading branch information
@taleinat @miss-islington
taleinat authored and miss-islington committed Jun 24, 2018
commit 0f6bfc6cc6f5bd9d5e546de79016d940c99a31c7
4 changes: 4 additions & 0 deletions Lib/idlelib/idle_test/test_configdialog.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,7 @@ def setUpClass(cls):
page = cls.page = dialog.fontpage
dialog.note.select(page)
page.set_samples = Func() # Mask instance method.
page.update()

@classmethod
def tearDownClass(cls):
Expand Down Expand Up @@ -210,6 +211,7 @@ class IndentTest(unittest.TestCase):
@classmethod
def setUpClass(cls):
cls.page = dialog.fontpage
cls.page.update()

def test_load_tab_cfg(self):
d = self.page
Expand Down Expand Up @@ -240,6 +242,7 @@ def setUpClass(cls):
page.paint_theme_sample = Func()
page.set_highlight_target = Func()
page.set_color_sample = Func()
page.update()

@classmethod
def tearDownClass(cls):
Expand Down Expand Up @@ -1085,6 +1088,7 @@ def setUpClass(cls):
dialog.note.select(page)
page.set = page.set_add_delete_state = Func()
page.upc = page.update_help_changes = Func()
page.update()

@classmethod
def tearDownClass(cls):
Expand Down