Skip to content

bpo-33873: Add warning when using less than 3 warmup runs in runtest.py. #7736

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vstinner merged 4 commits into from
Jun 16, 2018
Merged

bpo-33873: Add warning when using less than 3 warmup runs in runtest.py. #7736

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
677eff9
Add warning when using less than 3 warmup runs in `runtest.py`.
pablogsal Jun 15, 2018
cc7e0de
Move warning to Regrtest.run_test.
pablogsal Jun 15, 2018
d18f143
Mention --huntrleaks/-R in the warning message
pablogsal Jun 15, 2018
1696a14
fixup! Mention --huntrleaks/-R in the warning message
pablogsal Jun 16, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Move warning to Regrtest.run_test.
  • Loading branch information
@pablogsal
pablogsal committed Jun 15, 2018
commit cc7e0deff076b2fbee852be92009d5dfdbab11da
7 changes: 7 additions & 0 deletions Lib/test/libregrtest/main.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -462,6 +462,13 @@ def run_tests(self):
or self.tests or self.ns.args)):
self.display_header()

if self.ns.huntrleaks:
warmup, repetitions, _ = self.ns.huntrleaks
if warmup < 3:
msg = ("WARNING: Using less than 3 warmup repetitions can "
"give false positives!")
print(msg, file=sys.stdout, flush=True)

if self.ns.randomize:
print("Using random seed", self.ns.random_seed)

Expand Down
7 changes: 0 additions & 7 deletions Lib/test/libregrtest/runtest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,13 +98,6 @@ def runtest(ns, test):

output_on_failure = ns.verbose3

if ns.huntrleaks:
warmup, repetitions, _ = ns.huntrleaks
if warmup < 3:
msg = ("WARNING: Using less than 3 warmup repetitions can "
"give false positives!")
print(msg, file=sys.stdout, flush=True)

use_timeout = (ns.timeout is not None)
if use_timeout:
faulthandler.dump_traceback_later(ns.timeout, exit=True)
Expand Down