Skip to content

bpo-33671 / shutil.copyfile: use memoryview() with dynamic size on Windows #7681

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
giampaolo merged 16 commits into from
Jun 19, 2018
Merged

bpo-33671 / shutil.copyfile: use memoryview() with dynamic size on Windows #7681

Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
820fc21
bpo-33671: release sub-memoryview resources immediately
giampaolo Jun 12, 2018
7c55be5
rename OSX to macOS
giampaolo Jun 13, 2018
db6a9ad
add unit tests for copyfileobj
giampaolo Jun 13, 2018
090df6a
Remove _copybinfileobj() implementation
giampaolo Jun 13, 2018
df2354f
update doc
giampaolo Jun 13, 2018
4e2b9f8
update doc
giampaolo Jun 13, 2018
dae995a
update doc
giampaolo Jun 13, 2018
9f6cf1f
update doc
giampaolo Jun 13, 2018
06d3e7a
update doc
giampaolo Jun 13, 2018
8a3f88e
Reintroduce memoryview() variant of copyfileobj()
giampaolo Jun 13, 2018
f47c011
speed up test case by mocking file size instead of creating an actua…
giampaolo Jun 13, 2018
c3166e1
update doc
giampaolo Jun 13, 2018
89cd883
update comments
giampaolo Jun 14, 2018
be40ae1
rename var
giampaolo Jun 14, 2018
93ebc1f
Use dynamic memoryview() size based on file size
giampaolo Jun 14, 2018
9d93ce5
do not attempt to use sendfile() on OSX
giampaolo Jun 14, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
update doc
  • Loading branch information
@giampaolo
giampaolo committed Jun 13, 2018
commit 9f6cf1fd3ffbdcf5a0051d2cd9c1447d34718a50
5 changes: 5 additions & 0 deletions Doc/whatsnew/3.8.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,6 +167,11 @@ Changes in the Python API
* The :class:`cProfile.Profile` class can now be used as a context
manager. (Contributed by Scott Sanderson in :issue:`29235`.)

* :func:`shutil.copyfile`, :func:`shutil.copy`, :func:`shutil.copy2`,
:func:`shutil.copytree` and :func:`shutil.move` use platform-specific
"fast-copy" syscalls (see
:ref:`shutil-platform-dependent-efficient-copy-operations` section).

* :func:`shutil.copyfile` default buffer size on Windows was changed from
16 KiB to 1 MiB.

Expand Down