Skip to content

bpo-33802: Do not interpolate in ConfigParser while reading defaults #7524

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ambv merged 3 commits into from
Jun 8, 2018
Merged

bpo-33802: Do not interpolate in ConfigParser while reading defaults #7524

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8fe0a94
bpo-33802: Do not interpolate in ConfigParser while reading defaults
ambv Jun 8, 2018
ad238bb
Don't try to re-open an open temporary file; that doesn't work on Win…
ambv Jun 8, 2018
89bbe75
Use mkstemp, couldn't get NamedTemporaryFile to work
ambv Jun 8, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Use mkstemp, couldn't get NamedTemporaryFile to work
  • Loading branch information
@ambv
ambv committed Jun 8, 2018
commit 89bbe75907409496a876fb1a024a773262ee2ffb
11 changes: 5 additions & 6 deletions Lib/test/test_logging.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1473,13 +1473,12 @@ def test_defaults_do_no_interpolation(self):
formatter=default
handlers=console
""").strip()
fd, fn = tempfile.mkstemp(prefix='test_logging_', suffix='.ini')
try:
with tempfile.NamedTemporaryFile(
mode='w+t', encoding='utf-8', delete='False'
) as ntf:
ntf.write(ini)
os.write(fd, ini.encode('ascii'))
os.close(fd)
logging.config.fileConfig(
ntf.name,
fn,
defaults=dict(
version=1,
disable_existing_loggers=False,
Expand All @@ -1493,7 +1492,7 @@ def test_defaults_do_no_interpolation(self):
)
)
finally:
os.unlink(ntf.name)
os.unlink(fn)


class SocketHandlerTest(BaseTest):
Expand Down