Skip to content

Tweak .codedoc.yml to make it more useful #71

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
berkerpeksag merged 8 commits into from
Feb 14, 2017
Merged

Tweak .codedoc.yml to make it more useful #71

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
8590bb6
Tweak .codedoc.yml to make it more useful
berkerpeksag Feb 13, 2017
2efc23e
Merge branch 'master' into tweak-codecov
berkerpeksag Feb 13, 2017
c602eff
Turn off comments
berkerpeksag Feb 13, 2017
6300e70
Fix config
berkerpeksag Feb 13, 2017
ed506fa
Disable project level cverage
berkerpeksag Feb 13, 2017
a4f2f01
Fix config file
berkerpeksag Feb 13, 2017
8f4f8df
More cleanup
berkerpeksag Feb 13, 2017
57955fc
Add Grammar/*
berkerpeksag Feb 13, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Tweak .codedoc.yml to make it more useful
  • Loading branch information
@berkerpeksag
berkerpeksag committed Feb 13, 2017
commit 8590bb6b2197c23b17d27507ea07eca0c6972272
14 changes: 9 additions & 5 deletions .codecov.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,9 @@ codecov:
notify:
require_ci_to_pass: true
comment:
behavior: new
layout: header, diff
require_changes: false
behavior: once
layout: diff
require_changes: true
coverage:
precision: 2
range:
Expand All @@ -13,8 +13,12 @@ coverage:
round: down
status:
changes: false
patch: true
project: true
patch:
only_pulls: true
paths:

@briancurtin briancurtin Feb 13, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm guessing this means it only ends up being run for those directories, right? If so, that's good that it avoids being run on, e.g., Doc/* changes, but shouldn't it also run on directories like Objects/?

@berkerpeksag berkerpeksag Feb 13, 2017

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm guessing this means it only ends up being run for those directories, right?

Correct.

[...] but shouldn't it also run on directories like Objects/?

Good point. I'm reading docs again so I hopefully will have an answer :)

@berkerpeksag berkerpeksag Feb 13, 2017

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to https://docs.codecov.io/docs/commit-status#section-patch-status, we don't need to add specific directories. It should only look for the changes in PR.

We can also add directories to ignore: https://docs.codecov.io/docs/ignoring-paths

- Lib/*
- Modules/*
project: false
parsers:
gcov:
branch_detection:
Expand Down