Skip to content

gh-77578: IDLE Help - let users control font size #6665

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
csabella wants to merge 17 commits into from
Closed

gh-77578: IDLE Help - let users control font size #6665

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
066bcb7
bpo-25198: IDLE Help: Get font size from config and dynamically chang…
csabella Apr 30, 2018
42a1a74
Extract FontSizer class and fix tests.
csabella May 2, 2018
d25899d
Add return break to event handler.
csabella May 2, 2018
2fd7820
Separate event handlers from text changes.
csabella Sep 3, 2018
ff08ebf
Update event bindings, event handlers, and tests.
csabella Sep 7, 2018
a23cb1c
Move FontSizer to textview.
csabella Sep 28, 2018
e88f488
Retain Close button when increasing font size.
csabella Dec 15, 2018
90cb041
Use decorator for changing text widget
csabella Feb 2, 2019
e03e4b2
Adjust font tag sizes within FontSizer.
csabella Feb 2, 2019
645a0e0
Allow for sizing fonts defined in different ways.
csabella Feb 3, 2019
5c1d58a
Add tests for fonts defined as tuples.
csabella Feb 3, 2019
98295cb
Refactor return values
csabella Feb 3, 2019
d6f80e8
Update split to splitlist
csabella Feb 9, 2020
dab3eb5
Remove unrelated changes to editor.py
csabella Feb 9, 2020
26b3342
Update 2018-04-30-19-11-09.bpo-25198.yzJ3SL.rst
terryjreedy Sep 21, 2020
100bdea
Merge remote-tracking branch 'upstream/master' into pr_6665
terryjreedy Sep 21, 2020
803800d
Merge branch 'master' into bpo25198
terryjreedy Jan 25, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update split to splitlist
  • Loading branch information
@csabella
csabella committed Jun 20, 2020
commit d6f80e81820e9c00f69aebd870b1574d9e6e3c2d
12 changes: 6 additions & 6 deletions Lib/idlelib/idle_test/test_textview.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -281,11 +281,11 @@ def test_increase_font_size_tuple(self):
eq = self.assertEqual
text.focus_set()

eq(text.tk.split(text['font'])[1], '45')
eq(text.tk.splitlist(text['font'])[1], '45')
text.event_generate('<<increase_font_size>>')
eq(text.tk.split(text['font'])[1], '46')
eq(text.tk.splitlist(text['font'])[1], '46')
text.event_generate('<<increase_font_size>>')
eq(text.tk.split(text['font'])[1], '47')
eq(text.tk.splitlist(text['font'])[1], '47')

def test_decrease_font_size_tuple(self):
text = self.text
Expand All @@ -294,11 +294,11 @@ def test_decrease_font_size_tuple(self):
eq = self.assertEqual
text.focus_set()

eq(text.tk.split(text['font'])[1], '45')
eq(text.tk.splitlist(text['font'])[1], '45')
text.event_generate('<<decrease_font_size>>')
eq(text.tk.split(text['font'])[1], '44')
eq(text.tk.splitlist(text['font'])[1], '44')
text.event_generate('<<decrease_font_size>>')
eq(text.tk.split(text['font'])[1], '43')
eq(text.tk.splitlist(text['font'])[1], '43')


if __name__ == '__main__':
Expand Down
2 changes: 1 addition & 1 deletion Lib/idlelib/textview.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ def resize(fontname):
font = Font(self.text, name=fontname, exists=True)
font['size'] = new_size(font['size'])
except TclError:
font = list(self.text.tk.split(fontname))
font = list(self.text.tk.splitlist(fontname))
if len(font) > 1:
font[1] = new_size(int(font[1]))
return font
Expand Down