Skip to content

bpo-33083 - math.factorial accepts non-integral Decimal instances #6149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pablogsal merged 6 commits into from
Sep 3, 2018
Merged

bpo-33083 - math.factorial accepts non-integral Decimal instances #6149

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
da915c0
Use PyNumber_Index in the non-float branch of math_factorial and add …
pablogsal Mar 19, 2018
5ebef8b
Add News entry
pablogsal Mar 19, 2018
0494f10
Remove deprecation warning for floats
pablogsal Jul 30, 2018
7a1ed88
Correct NEWS entry
pablogsal Jul 30, 2018
33060fe
add a few missing spaces
taleinat Jul 30, 2018
1c5bd86
Correct NEWS entry
pablogsal Jul 30, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Correct NEWS entry
  • Loading branch information
@pablogsal
pablogsal committed Sep 3, 2018
commit 7a1ed88b8baf27b33a03f9b8bd09a2c0fd092cb8
4 changes: 2 additions & 2 deletions Misc/NEWS.d/next/Core and Builtins/2018-03-19-00-59-20.bpo-33083.Htztjl.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
math.factorial no longer accept arguments that are not int-like. A
DeprecationWarning is emmited if the argument is a float. Patch by Pablo
math.factorial no longer accepts arguments that are not int-like. A
DeprecationWarning is emitted if the argument is a float. Patch by Pablo
Galindo.