Skip to content

String annotations [PEP 563] #4390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ambv merged 7 commits into from
Jan 26, 2018
Merged

String annotations [PEP 563] #4390

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
1a87ea0
Document `from __future__ import annotations` (PEP 563)
ambv Nov 10, 2017
863d3e9
Plumbing for `from __future__ import annotations` (PEP 563)
ambv Nov 10, 2017
bc3ad37
Implement unparsing the AST back to string form
ambv Nov 10, 2017
7f88115
Response to Serhiy's review
Dec 5, 2017
08f8600
Strings are no longer treated special
Dec 31, 2017
de9e5b0
f-string support
ambv Jan 15, 2018
26c028c
compatibility typo
ambv Jan 25, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Strings are no longer treated special 
See:
https://www.python.org/dev/peps/pep-0563/#passing-string-literals-in-annotations-verbatim-to-annotations
  • Loading branch information
Lukasz Langa
Lukasz Langa committed Dec 31, 2017
commit 08f86007bae1f0df2b4cbf5e76ec46f3c73746ac
3 changes: 1 addition & 2 deletions Include/ast.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,7 @@ PyAPI_FUNC(mod_ty) PyAST_FromNodeObject(
/* _PyAST_ExprAsUnicode is defined in ast_unparse.c */
PyAPI_FUNC(PyObject *) _PyAST_ExprAsUnicode(
expr_ty e,
int omit_parens,
int omit_string_brackets);
int omit_parens);

#endif /* !Py_LIMITED_API */

Expand Down
5 changes: 1 addition & 4 deletions Lib/test/test_future.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,10 +133,7 @@ def assertAnnotationEqual(
self, annotation, drop_parens=False, is_tuple=False
):
actual = self.getActual(annotation)
if annotation.startswith("'"):
# strings are passed verbatim
expected = eval(annotation)
elif is_tuple:
if is_tuple:
expected = annotation[1:-1]
else:
expected = annotation
Expand Down
Loading