Skip to content

bpo-28180: Fix the implementation of PEP 538 on Android #4334

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
xdegaye merged 5 commits into from
Nov 12, 2017
Merged

bpo-28180: Fix the implementation of PEP 538 on Android #4334

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
b897e38
Fix the implementation of PEP 538 on Android
xdegaye Nov 8, 2017
bdf26ce
Implementation of _Py_SetLocaleFromEnv()
xdegaye Nov 11, 2017
3a56004
Revert from 1st commit unneeded change now
xdegaye Nov 11, 2017
29287d7
Add a NEWS entry
xdegaye Nov 12, 2017
3cc7417
Update the NEWS entry.
xdegaye Nov 12, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add a NEWS entry
  • Loading branch information
@xdegaye
xdegaye committed Nov 12, 2017
commit 29287d71922d29bbe4bdb2a6bfe49bd5715a7716
3 changes: 3 additions & 0 deletions Misc/NEWS.d/next/Core and Builtins/2017-11-12-11-44-22.bpo-28180.HQX000.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
The platform dependent handling of setting the locale from the environment is

@ncoghlan ncoghlan Nov 12, 2017

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's probably clearer to mention the new internal API by name. Something like

A new internal _Py_SetLocaleFromEnv(category) helper function has been added in order
to improve the consistency of behaviour across different libc implementations (e.g. Android
doesn't support setting the locale from the environment by default)

@xdegaye xdegaye Nov 12, 2017

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Nick :-)

now consolidated into the standard behavior on platforms whose `setlocale()`
function do not set the locale from the environment (e.g. Android).